Merge pull request #337 from skyway/staging

Deploy to master (v4.4.5)
skyway · Jul 28, 2022 · 818e44f · 818e44f
2 parents c4c7db2 + 3105777
commit 818e44f
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,13 @@
 # Changelog
 
 ## release note
+
+## [v4.4.5](https://github.com/skyway/skyway-js-sdk/releases/tag/v4.4.5) - 2022-07-28
+
+### Fixed
+
+- Fixed a problem that could cause `TypeError: Cannot read properties of null (reading 'addIceCandidate')` error if the `close` method of `MediaConnection` was called before the  connection was established. ([#336](https://github.com/skyway/skyway-js-sdk/pull/336))
+
 ## [v4.4.4](https://github.com/skyway/skyway-js-sdk/releases/tag/v4.4.4) - 2022-03-17
 
 ### Fixed

diff --git a/README.md b/README.md
@@ -7,13 +7,13 @@
 Add the following script tag to your html file.
 
 ```html
-<script type="text/javascript" src="https://cdn.webrtc.ecl.ntt.com/skyway-4.4.4.js"></script>
+<script type="text/javascript" src="https://cdn.webrtc.ecl.ntt.com/skyway-4.4.5.js"></script>
 ```
 
 You can then use the `Peer` object to start connecting.
 For more details, check out the [Tutorial](https://webrtc.ecl.ntt.com/en/js-tutorial.html). ([日本語](https://webrtc.ecl.ntt.com/js-tutorial.html))
 
-To use the compressed version, add `.min` to the end of the file name, like `skyway-4.4.4.min.js`.
+To use the compressed version, add `.min` to the end of the file name, like `skyway-4.4.5.min.js`.
 
 ### Installing using npm to use with a bundler (e.g. webpack or browserify)
 

diff --git a/examples/p2p-data/index.html b/examples/p2p-data/index.html
@@ -27,7 +27,7 @@ <h1 class="heading">P2P Data example</h1>
       </div>
       <p class="meta" id="js-meta"></p>
     </div>
-    <script src="//cdn.webrtc.ecl.ntt.com/skyway-4.4.4.js"></script>
+    <script src="//cdn.webrtc.ecl.ntt.com/skyway-4.4.5.js"></script>
     <script src="../_shared/key.js"></script>
     <script src="./script.js"></script>
   </body>

diff --git a/examples/p2p-media/index.html b/examples/p2p-media/index.html
@@ -26,7 +26,7 @@ <h1 class="heading">P2P Media example</h1>
       </div>
       <p class="meta" id="js-meta"></p>
     </div>
-    <script src="//cdn.webrtc.ecl.ntt.com/skyway-4.4.4.js"></script>
+    <script src="//cdn.webrtc.ecl.ntt.com/skyway-4.4.5.js"></script>
     <script src="../_shared/key.js"></script>
     <script src="./script.js"></script>
   </body>

diff --git a/examples/room/index.html b/examples/room/index.html
@@ -32,7 +32,7 @@ <h1 class="heading">Room example</h1>
       </div>
       <p class="meta" id="js-meta"></p>
     </div>
-    <script src="//cdn.webrtc.ecl.ntt.com/skyway-4.4.4.js"></script>
+    <script src="//cdn.webrtc.ecl.ntt.com/skyway-4.4.5.js"></script>
     <script src="../_shared/key.js"></script>
     <script src="./script.js"></script>
   </body>

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "skyway-js",
-  "version": "4.4.4",
+  "version": "4.4.5",
   "description": "The official JavaScript SDK for SkyWay",
   "main": "dist/skyway.js",
   "types": "skyway-js.d.ts",

diff --git a/skyway-js.d.ts b/skyway-js.d.ts
@@ -1,4 +1,4 @@
-// Type definitions for SkyWay@4.4.4
+// Type definitions for SkyWay@4.4.5
 // Project: https://github.com/skyway/skyway-js-sdk
 // Definitions by: Yuji Sugiura <https://github.com/leader22>
 

diff --git a/src/peer/negotiator.js b/src/peer/negotiator.js
@@ -233,6 +233,10 @@ class Negotiator extends EventEmitter {
    * @return {Promise<void>} Promise that resolves when handling candidate is done.
    */
   async handleCandidate(candidate) {
+    if (!this._pc) {
+      return;
+    }
+
     await this._pc
       .addIceCandidate(new RTCIceCandidate(candidate))
       .then(() => logger.log('Successfully added ICE candidate'))