fix: re-land papyrus error handling fix

[Pospelove]

Reverts #2314

---

Important

Reintroduces error handling improvements in Papyrus VM by replacing exceptions with logging and default returns, updating related tests.

• Error Handling:
  • Replaced exceptions with spdlog logging in ActivePexInstance.cpp, VarValue.cpp, and VirtualMachine.cpp.
  • Functions like ExecuteOpCode, GetVariableValueByName, and CallMethod now log errors and return default values instead of throwing exceptions.
• Function Modifications:
  • Added noexcept to ExecuteAll and ExecuteOpCode in ActivePexInstance.h.
  • Removed ExceptionHandler from VirtualMachine.h.
• Test Updates:
  • Removed exception-based tests in VarValueTest.cpp for identifier and nonexistent types.
  • Updated tests to check for default return values instead of exceptions.

^{This description was created by for cd71610. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to cd71610 in 50 seconds

More details

• Looked at 953 lines of code in 7 files
• Skipped 0 files when reviewing.
• Skipped posting 11 drafted comments based on config settings.

1. unit/VarValueTest.cpp:9

• Draft comment:
  Good tests for boolean comparisons. The use of REQUIRE with casting to bool is clear.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

2. unit/VarValueTest.cpp:19

• Draft comment:
  Test for the assignment operator on owning objects is clear. Consider covering deep copy edge cases further, though current test verifies that stringHolder is deep-copied.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

3. unit/VarValueTest.cpp:44

• Draft comment:
  Equality operator tests for objects are straightforward. Test verifies that equal objects (by value) compare equal and different values compare unequal.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

4. unit/VarValueTest.cpp:82

• Draft comment:
  Tests for wrong types and casting functions look adequate. Ensure that numeric conversions (e.g. from string to int or float) behave as expected.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

5. unit/VarValueTest.cpp:97

• Draft comment:
  The strcat implicit cast test is concise and confirms the functionality provided by OpcodesImplementation::StrCat.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

6. unit/VarValueTest.cpp:105

• Draft comment:
  Mixed arithmetics test checks various math operations and matches string output. The use of string streams validates the print representation.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

7. unit/VarValueTest.cpp:124

• Draft comment:
  Cast to string tests cover both numeric and array cases. The expected output of '[None, None]' for an array of None is verified.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

8. unit/VarValueTest.cpp:136

• Draft comment:
  Final operator== test is clear in verifying string equality and differences.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

9. papyrus-vm/src/papyrus-vm-lib/VarValue.cpp:221

• Draft comment:
  In the ToDouble function, the kType_Float case casts the value to int32_t before conversion, losing the fractional part. Use the float value directly (e.g. v.data.f) instead.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

10. papyrus-vm/src/papyrus-vm-lib/VarValue.cpp:327

• Draft comment:
  The operator/ for integers returns 1 when division by zero occurs, which can mask errors. Consider explicitly handling division by zero instead of defaulting to 1.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

11. papyrus-vm/src/papyrus-vm-lib/VarValue.cpp:629

• Draft comment:
  Using a precision value of 9000 in snprintf for CastToString in the float case is excessively high and may cause formatting issues. Consider using a more typical precision value.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_BoWUx2EhFMmqMTiy

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[nic11]

I would still first implement execution budget

[Wedmer]

Maybe it is better to declare and initialize this before try .

[Wedmer]

Maybe it's better initialize it once somewhere before try.