Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libespm): disable search for 0 formId in CombineBrowser #2296

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Jan 30, 2025

Important

Add check in CombineBrowser::LookupById to return empty result for combFormId 0, preventing irrelevant TES4 records.

  • Behavior:
    • In CombineBrowser::LookupById, add check to return empty LookupResult if combFormId is 0, preventing irrelevant TES4 records from being found.

This description was created by Ellipsis for 7b22b89. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7b22b89 in 14 seconds

More details
  • Looked at 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. libespm/src/CombineBrowser.cpp:25
  • Draft comment:
    Consider adding a check for combFormId == 0 in other functions that use combFormId, such as LookupByIdAll, to prevent unnecessary processing.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_kUiL97ZMNOxzyd41


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Pospelove Pospelove requested a review from nic11 January 30, 2025 12:31
@Pospelove Pospelove merged commit 148ba42 into skyrim-multiplayer:main Jan 30, 2025
14 checks passed
@Pospelove Pospelove deleted the espm0 branch January 30, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants