-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add inviter and PR manager handling in AuthService #2288
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 6a77930 in 1 minute and 37 seconds
More details
- Looked at
181
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skymp5-client/src/services/services/authService.ts:335
- Draft comment:
ThepostPrManager
method is using the same API route aspostInviter
. It should have a different route specific to setting the PR manager. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_UCpSImDCw8KUHiht
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
} | ||
|
||
private postPrManager(token: string) { | ||
const route = `/api/users/me/inviter`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The postPrManager
method is using the same API route as postInviter
. It should have a different route specific to setting the PR manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 0243fb2 in 17 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skymp5-client/src/services/services/authService.ts:254
- Draft comment:
The route forpostPrManager
was corrected from/api/users/me/inviter
to/api/users/me/prManager
. This change aligns with the intended functionality described in the PR description. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_ctRZrQq8uRt8lidQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Adds inviter and PR manager handling in
AuthService
, integrating them into the login process with new interfaces and methods.SetInviterRequestBody
andSetPrManagerRequestBody
for inviter and PR manager request bodies.InstallationData
to store optionalinviterUserId
andprManagerUserId
.postInviter()
andpostPrManager()
methods inauthService.ts
to send inviter and PR manager data.postInviter()
andpostPrManager()
incheckLoginState()
to execute after successful login.readInstallationDataFromDisk()
to read installation data fromSkyMP/installation-data.json
.authService.ts
.This description was created by for 0243fb2. It will automatically update as commits are pushed.