Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(skymp5-server): skip ACTI and FURN objects in AttachSaveStorage #2287

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Dec 31, 2024

Important

Add condition in AttachSaveStorage to skip ACTI and FURN objects in PartOne.cpp.

  • Behavior:
    • In AttachSaveStorage in PartOne.cpp, added condition to skip objects of type ACTI and FURN when processing FF objects.
    • Logs a message when skipping these objects, indicating potential future overwriting.

This description was created by Ellipsis for cce9b0e. It will automatically update as commits are pushed.

@ellipsis-dev ellipsis-dev bot changed the title . fix: skip ACTI and FURN objects in AttachSaveStorage Dec 31, 2024
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to cce9b0e in 12 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skymp5-server/cpp/server_guest_lib/PartOne.cpp:314
  • Draft comment:
    Consider storing lookupRes.rec->GetType() in a variable to avoid repeated calls. This applies to the newly added condition as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The added condition checks for specific record types and logs a message if they are found. This is a reasonable addition, but it could be optimized by reducing repeated calls to lookupRes.rec->GetType().

Workflow ID: wflow_Df7yzqvouMHlqowm


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Pospelove Pospelove changed the title fix: skip ACTI and FURN objects in AttachSaveStorage perf(skymp5-server): skip ACTI and FURN objects in AttachSaveStorage Dec 31, 2024
@Pospelove Pospelove merged commit 7ac8f8b into skyrim-multiplayer:main Jan 10, 2025
16 checks passed
@Pospelove Pospelove deleted the happynewyear branch January 10, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant