refact(skymp5-server): replace Axios with fetch-retry in login.ts

[Pospelove]

Important

Replace Axios with fetch-retry for HTTP requests in login.ts, adding retry logic and updating dependencies in package.json.

• Dependencies:
  • Add @types/node and fetch-retry to package.json.
• HTTP Requests:
  • Replace Axios with fetch-retry in login.ts for HTTP requests.
  • Add getFetchOptions() in login.ts for retry logic with 10 retries on network errors or 5xx status codes.
• Error Handling:
  • Update error handling in getUserProfile() and Discord API requests in login.ts to use fetch-retry responses.

^{This description was created by for 00910f2. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 00910f2 in 2 minutes and 54 seconds

More details

• Looked at 167 lines of code in 2 files
• Skipped 1 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. skymp5-server/ts/systems/login.ts:4

• Draft comment:
  Consider renaming the import to fetchRetryFactory or similar to clarify its usage.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The fetch-retry import is not used directly; instead, fetchRetry.default(global.fetch) is used. This can be confusing.

2. skymp5-server/ts/systems/login.ts:239

• Draft comment:
  Consider initializing fetchRetry in the constructor for clarity.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The fetchRetry initialization is done at the class level, which is fine, but it might be clearer to initialize it in the constructor.

3. skymp5-server/ts/systems/login.ts:59

• Draft comment:
  Consider including the URL or request details in the error message for better debugging.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The error occurs in getUserProfile() which already has good error handling. The URL can be derived from the masterUrl and myAddr variables. The status code is included. There's extensive logging elsewhere. Adding the URL here would be redundant since it's logged in other places and can be determined from the context.
  The URL could be helpful for immediate debugging without having to look at other log lines. The current error message is somewhat terse.
  The error is already identifiable through the function name prefix and status code. The URL is logged in multiple other places and can be reconstructed from class variables.
  The comment suggests a minor improvement that would be redundant given the existing logging and error handling. The current error message is sufficient.

4. skymp5-server/ts/systems/login.ts:198

• Draft comment:
  Consider implementing a fallback or additional handling for errors when sending messages to Discord.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The fetchRetry call for sending a message to Discord logs an error but does not handle it further. It might be useful to have a fallback or retry mechanism.

Workflow ID: wflow_o9aNSghCJOQzSmvt

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[Pospelove]

@nic11 please review for obvious mistakes