[ENH] Consolidate quantile parameterized distributions in few classes #235
Labels
API design
API design & software architecture
enhancement
implementing algorithms
Implementing algorithms, estimators, objects native to skpro
module:probability&simulation
probability distributions and simulators
module:regression
probabilistic regression module
@FelixWick, @setoguchi-naoki, @Ram0nB I think we should consolidate the three curent quantile parameterized distribution (QPD) classes into a single one, and move the distribution logic in the quantile regressor in another QPD related class.
This idea is based on two observations:
MultipleQuantileRegressor
is one way to construct a QPD with arbitrary number of input quantile predictions/values. PR showing how this could look like here: [ENH] empirical quantile parameterized distribution #236CyclicBoosting
, are spread across three classes which seem a bit redundant. They are also being reworked in [ENH] update Johnson QPDistributions with bugfixes and vectorization (cyclic-boosting ver.1.4.0) #232, related to thecyclic_boosting 1.4.0
release.I would suggest the following end state:
the logic in
MultipleQuantileRegressor
moves into a QPD, to which we can later add different interpolation modes and basis functions.I would suggest replacing the three
QPD_X
distributions by a single class for Johnson QPD,QPD_Johnson
, or similar. This can have a parameterbounding
which can be"bounded"
,"unbounded"
,"semi"
, mapping onto the logic in the three current classes.Do you have any thoughts about this suggestion? It might simplify the interface(s) of the connected regressors as well.
The text was updated successfully, but these errors were encountered: