Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #56

Merged
merged 1 commit into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions src/TeamUp.Application/Events/GetEvents/GetEvetnsQueryHandlers.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@

namespace TeamUp.Application.Events.GetEvents;

internal sealed class GetEventsQueryHandlers : IQueryHandler<GetEventsQuery, Result<List<EventSlimResponse>>>
internal sealed class GetEventsQueryHandler : IQueryHandler<GetEventsQuery, Result<List<EventSlimResponse>>>
{
private readonly IAppQueryContext _appQueryContext;
private readonly IDateTimeProvider _dateTimeProvider;

public GetEventsQueryHandlers(IAppQueryContext appQueryContext, IDateTimeProvider dateTimeProvider)
public GetEventsQueryHandler(IAppQueryContext appQueryContext, IDateTimeProvider dateTimeProvider)
{
_appQueryContext = appQueryContext;
_dateTimeProvider = dateTimeProvider;
Expand Down Expand Up @@ -75,26 +75,9 @@ public async Task<Result<List<EventSlimResponse>>> Handle(GetEventsQuery query,
EventType = team.EventTypes.First(et => et.Id == e.EventTypeId).Name
})
.OrderBy(e => e.FromUtc)
.ToList(),
})
.FirstOrDefaultAsync(team => team.Id == query.TeamId, ct);

/*
var team2 = await _appQueryContext.Teams
.Where(team => team.Id == query.TeamId)
.Select(team => new
{
Initiator = team.Members
.Where(member => member.UserId == query.InitiatorId)
.Select(member => new
{
member.Id,
member.Nickname,
})
.FirstOrDefault()
.ToList()
})
.FirstOrDefaultAsync(ct);
*/

return team
.EnsureNotNull(TeamErrors.TeamNotFound)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ public async Task<Result<List<TeamSlimResponse>>> Handle(GetUserTeamsQuery query
{
TeamId = team.Id,
Name = team.Name,
NumberOfTeamMembers = team.NumberOfMembers
})
.ToListAsync(ct);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ public async Task<Result> Handle(ActivateAccountCommand command, CancellationTok
var user = await _userRepository.GetUserByIdAsync(command.UserId, ct);
return await user
.EnsureNotNull(UserErrors.UserNotFound)
.Tap(user => user.Activate())
.TapAsync(_ => _unitOfWork.SaveChangesAsync(ct))
.ToResultAsync();
.Then(user => user.Activate())
.TapAsync(() => _unitOfWork.SaveChangesAsync(ct));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ public async Task<Result> Handle(CompleteRegistrationCommand command, Cancellati
var user = await _userRepository.GetUserByIdAsync(command.UserId, ct);
return await user
.EnsureNotNull(UserErrors.UserNotFound)
.Tap(user => user.CompleteGeneratedRegistration(_passwordService.HashPassword(command.Password)))
.TapAsync(_ => _unitOfWork.SaveChangesAsync(ct))
.ToResultAsync();
.Then(user => user.CompleteGeneratedRegistration(_passwordService.HashPassword(command.Password)))
.TapAsync(() => _unitOfWork.SaveChangesAsync(ct));
}
}
1 change: 1 addition & 0 deletions src/TeamUp.Contracts/Teams/TeamSlimResponse.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ public sealed class TeamSlimResponse
{
public required TeamId TeamId { get; init; }
public required string Name { get; init; }
public required int NumberOfTeamMembers { get; init; }
}
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ public async Task GetUserTeams_Should_ReturnTeams_ThatUserIsMemberOf()
{
TeamId = team.Id,
Name = team.Name,
NumberOfTeamMembers = team.NumberOfMembers
});

var otherTeam = TeamGenerators.Team.WithOneOwner(members.First());
Expand Down
Loading