fixed concurrency tokens in migrations for postgres, added indexes in…

… migrations, added checking for unque constraint, added test for race conditions, additional fixes

src/TeamUp.Infrastructure/Core/UnitOfWork.cs

@@ -1,6 +1,8 @@
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.Logging;
 
+using Npgsql;
+
 using RailwayResult;
 using RailwayResult.Errors;
 
@@ -12,8 +14,12 @@ namespace TeamUp.Infrastructure.Core;
 
 internal sealed class UnitOfWork : IUnitOfWork
 {
-	private static readonly ConflictError ConcurrencyError = new("Database.Concurrency.Conflict", "Multiple concurrent update requests have occurred.");
-	private static readonly InternalError UnexpectedError = new("Database.InternalError", "Unexpected error have occurred.");
+	//https://www.postgresql.org/docs/current/errcodes-appendix.html
+	private const string UniqueConstraintViolation = "23505";
+
+	internal static readonly ConflictError ConcurrencyError = new("Database.Concurrency.Conflict", "Multiple concurrent update requests have occurred.");
+	internal static readonly ConflictError UniqueConstraintError = new("Database.Constraints.PropertyConflict", "Unique property conflict has occurred.");
+	internal static readonly InternalError UnexpectedError = new("Database.InternalError", "Unexpected error have occurred.");
 
 	private readonly ApplicationDbContext _context;
 	private readonly IDomainEventsDispatcher _eventsDispatcher;
@@ -42,7 +48,13 @@ public async Task<Result> SaveChangesAsync(CancellationToken ct = default)
 		}
 		catch (DbUpdateException ex)
 		{
-			_logger.LogError(ex, "Database Update Exception");
+			_logger.LogError(ex.InnerException, "Database Update Exception");
+
+			if (ex.InnerException is PostgresException pex && pex.SqlState == UniqueConstraintViolation)
+			{
+				return UniqueConstraintError;
+			}
+
 			return UnexpectedError;
 		}
 	}

src/TeamUp.Infrastructure/Persistence/Domain/Events/EventConfiguration.cs

@@ -26,5 +26,15 @@ protected override void ConfigureEntity(EntityTypeBuilder<Event> eventEntityBuil
 			.WithOne()
 			.HasForeignKey(eventResponse => eventResponse.EventId)
 			.OnDelete(DeleteBehavior.Cascade);
+
+		eventEntityBuilder
+			.HasIndex(e => e.TeamId);
+
+		eventEntityBuilder
+			.HasIndex(e => e.EventTypeId);
+
+		eventEntityBuilder
+			.Property<uint>("RowVersion")
+			.IsRowVersion();
 	}
 }

src/TeamUp.Infrastructure/Persistence/Domain/Events/EventResponseConfiguration.cs

@@ -1,7 +1,6 @@
 using Microsoft.EntityFrameworkCore.Metadata.Builders;
 
 using TeamUp.Contracts.Events;
-using TeamUp.Domain.Aggregates.Events;
 using TeamUp.Domain.Aggregates.Teams;
 
 using EventResponse = TeamUp.Domain.Aggregates.Events.EventResponse;
@@ -26,5 +25,12 @@ protected override void ConfigureEntity(EntityTypeBuilder<EventResponse> eventRe
 		eventResponseEntityBuilder
 			.Property(eventResponse => eventResponse.Message)
 			.HasMaxLength(255);
+
+		eventResponseEntityBuilder
+			.HasIndex(eventResponse => eventResponse.EventId);
+
+		eventResponseEntityBuilder
+			.HasIndex(eventResponse => new { eventResponse.EventId, eventResponse.TeamMemberId })
+			.IsUnique();
 	}
 }

src/TeamUp.Infrastructure/Persistence/Domain/Invitations/InvitationConfiguration.cs

@@ -14,15 +14,21 @@ protected override void ConfigureEntity(EntityTypeBuilder<Invitation> invitation
 		invitationEntityBuilder
 			.HasOne<User>()
 			.WithMany()
-			.HasForeignKey(e => e.RecipientId);
+			.HasForeignKey(invitation => invitation.RecipientId);
 
 		invitationEntityBuilder
 			.HasOne<Team>()
 			.WithMany()
-			.HasForeignKey(e => e.TeamId);
+			.HasForeignKey(invitation => invitation.TeamId);
 
 		invitationEntityBuilder
-			.Property<byte[]>("RowVersion")
-			.IsRowVersion();
+			.HasIndex(invitation => invitation.RecipientId);
+
+		invitationEntityBuilder
+			.HasIndex(invitation => invitation.TeamId);
+
+		invitationEntityBuilder
+			.HasIndex(invitation => new { invitation.TeamId, invitation.RecipientId })
+			.IsUnique();
 	}
 }

src/TeamUp.Infrastructure/Persistence/Domain/Teams/TeamMemberConfiguration.cs

@@ -26,7 +26,10 @@ protected override void ConfigureEntity(EntityTypeBuilder<TeamMember> teamMember
 			.HasMaxLength(255);
 
 		teamMemberEntityBuilder
-			.Property<byte[]>("RowVersion")
+			.HasIndex(team => team.TeamId);
+
+		teamMemberEntityBuilder
+			.Property<uint>("RowVersion")
 			.IsRowVersion();
 	}
 }

src/TeamUp.Infrastructure/Persistence/Domain/Users/UserConfiguration.cs

@@ -44,7 +44,7 @@ protected override void ConfigureEntity(EntityTypeBuilder<User> userEntityBuilde
 			.OnDelete(DeleteBehavior.Cascade);
 
 		userEntityBuilder
-			.Property<byte[]>("RowVersion")
+			.Property<uint>("RowVersion")
 			.IsRowVersion();
 	}
 }

src/TeamUp.Infrastructure/Persistence/Migrations/20240327170351_FixConcurrencyAndIndexes.cs

@@ -0,0 +1,74 @@
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace TeamUp.Infrastructure.Persistence.Migrations
+{
+    /// <inheritdoc />
+    public partial class FixConcurrencyAndIndexes : Migration
+    {
+        /// <inheritdoc />
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.AddColumn<uint>(
+                name: "xmin",
+                table: "Users",
+                type: "xid",
+                rowVersion: true,
+                nullable: false,
+                defaultValue: 0u);
+
+            migrationBuilder.AddColumn<uint>(
+                name: "xmin",
+                table: "TeamMember",
+                type: "xid",
+                rowVersion: true,
+                nullable: false,
+                defaultValue: 0u);
+
+            migrationBuilder.AddColumn<uint>(
+                name: "xmin",
+                table: "Events",
+                type: "xid",
+                rowVersion: true,
+                nullable: false,
+                defaultValue: 0u);
+
+            migrationBuilder.CreateIndex(
+                name: "IX_Invitations_TeamId_RecipientId",
+                table: "Invitations",
+                columns: new[] { "TeamId", "RecipientId" },
+                unique: true);
+
+            migrationBuilder.CreateIndex(
+                name: "IX_EventResponse_EventId_TeamMemberId",
+                table: "EventResponse",
+                columns: new[] { "EventId", "TeamMemberId" },
+                unique: true);
+        }
+
+        /// <inheritdoc />
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.DropIndex(
+                name: "IX_Invitations_TeamId_RecipientId",
+                table: "Invitations");
+
+            migrationBuilder.DropIndex(
+                name: "IX_EventResponse_EventId_TeamMemberId",
+                table: "EventResponse");
+
+            migrationBuilder.DropColumn(
+                name: "xmin",
+                table: "Users");
+
+            migrationBuilder.DropColumn(
+                name: "xmin",
+                table: "TeamMember");
+
+            migrationBuilder.DropColumn(
+                name: "xmin",
+                table: "Events");
+        }
+    }
+}