Fixed Generating Random Team Members (#41)

* fixed non repeatable picking when generating random members
skrasekmichael · Mar 13, 2024 · 95c3bbc · 95c3bbc
1 parent 348b99b
commit 95c3bbc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/tests/TeamUp.Tests.Common/DataGenerators/TeamGeneratorExtensions.cs b/tests/TeamUp.Tests.Common/DataGenerators/TeamGeneratorExtensions.cs
@@ -43,7 +43,7 @@ public static TeamGenerator WithRandomMembers(this TeamGenerator teamGenerator,
 
 		return teamGenerator
 			.RuleFor(TeamGenerators.TEAM_MEMBERS_FIELD, (f, t) => f
-				.Make(count, index => f.PopRandom(new List<User>(pot))
+				.Make(() => new List<User>(pot), count, (list, index) => f.PopRandom(list)
 					.Map(user => TeamGenerators.TeamMember
 						.RuleForBackingField(tm => tm.TeamId, t.Id)
 						.RuleForBackingField(tm => tm.UserId, user.Id)

diff --git a/tests/TeamUp.Tests.Common/Extensions/FakerExtensions.cs b/tests/TeamUp.Tests.Common/Extensions/FakerExtensions.cs
@@ -20,6 +20,12 @@ public static T PopRandom<T>(this Faker faker, List<T> list) where T : class
 		return elem;
 	}
 
+	public static IList<TOut> Make<TOut, TListElem>(this Faker _, Func<List<TListElem>> prepareList, int count, Func<List<TListElem>, int, TOut> action)
+	{
+		var list = prepareList();
+		return Enumerable.Range(1, count).Select((index, elem) => action(list, index)).ToList();
+	}
+
 	public static Faker<T> UsePrivateConstructor<T>(this Faker<T> faker) where T : class
 		=> faker.CustomInstantiator(f => (Activator.CreateInstance(typeof(T), nonPublic: true) as T)!);