Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility #13

Open
montogeek opened this issue Jun 30, 2018 · 2 comments
Open

Accessibility #13

montogeek opened this issue Jun 30, 2018 · 2 comments

Comments

@montogeek
Copy link

montogeek commented Jun 30, 2018

Hi Skip!

There was a contribution on webpack website regarding accessibility which added a lot of aria attributes to elements, when merging master into new rebuild branch I find myself unable to add those attributes since react-banner doesn't expose a way to set them.

Would you accept a PR to add those attributes as props with sensible defaults?

Edit: PR webpack/webpack.js.org#2294

@skipjack
Copy link
Owner

skipjack commented Jul 1, 2018

Yep, will do thanks for reporting this.

@skipjack
Copy link
Owner

skipjack commented Jul 2, 2018

Whoops, read that wrong. Yeah, if you'd like to submit a PR that'd be great. Honestly some of those don't even need to be props, I think they can just be set permanently (e.g. role="search"). I'd like to keep things as simple as possible but if you think there's some that are worth allowing customization for that's fine.

@skipjack skipjack changed the title Accesibility Accessibility Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants