Fix bug with reward for an inactive node #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DimaStebaev
commented
Dec 29, 2023
•
DimaStebaev
commented
- fix bug in Sequence.Iterator
- add tests
- should not pay reward for inactive nodes
- should calculate partial segments
- add timestamp to events
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #63 +/- ##
===========================================
+ Coverage 82.71% 83.66% +0.94%
===========================================
Files 16 16
Lines 758 765 +7
Branches 112 113 +1
===========================================
+ Hits 627 640 +13
+ Misses 131 125 -6 ☔ View full report in Codecov by Sentry. |
yavrsky
approved these changes
Dec 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.