Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String select function and other improvements #57

Merged
merged 49 commits into from
Feb 15, 2025
Merged

String select function and other improvements #57

merged 49 commits into from
Feb 15, 2025

Conversation

azumakuniyuki
Copy link
Member

No description provided.

@azumakuniyuki
Implement sisimai/string.Select() function
894fadd
@azumakuniyuki
#41 Test suites for sisimai/string.Select() 894fadd
00626f0
@azumakuniyuki
Use sisimai/string.Select() for getting the error code of i.ua 894fadd
7b5f96c
@azumakuniyuki
Use sisimai/string.Select() for getting the error code of GoDaddy 894…
b10fcc9 
…fadd
@azumakuniyuki
Use sisimai/string.Select() for getting the error code of Cox 894fadd
50dbae2
@azumakuniyuki
Use sisimai/string.Select() for getting the value of List-ID: header
9652029
@azumakuniyuki
Use sisimai/string.Select() for getting a (comment string) 894fadd
61e8f6d
@azumakuniyuki
Tiny variable scope improvement
f676dc3
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting a recipient address f…
945c3fa 
…rom error messages
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting a recipient address f…
8233b3f 
…rom To: header in the original message
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting a recipient address f…
82c7954 
…rom To: header in the original message
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting an error code
3240495
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting a recipient address f…
0134733 
…rom the error message
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting a recipient address f…
3f0303c 
…rom To: header in the original message
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting diagnostic informatio…
b358fdf 
…n from the error messages
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting a date string from th…
a67cde4 
…e error message
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting a recipient address f…
84b938e 
…rom the error messages
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting a recipient address f…
d7b4743 
…rom To: header in the original message
@azumakuniyuki
894fadd Use sisimai/string.Select() for checking IPv4 or IPv6 address…
e666278 
… in the email address
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting a recipient address f…
ff8993d 
…rom the error message
@azumakuniyuki
Tiny variable scope improvement
a76526c
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting the Date: and the Sub…
df0ea66 
…ject: values from the error message
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting a JSON string notifie…
01e7e20 
…d from Amazon SNS
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting recipient addresses f…
6da435b 
…rom the error message
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting a recipient address f…
4040052 
…rom To: header in the original message
@azumakuniyuki
Tiny variable scope improvement 4040052
0a1524f
@azumakuniyuki
Variable scopes improved
e21b6e2
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting a remote host address…
9282b4d 
… from error messages
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting an erorr code number …
720c39a 
…from error messages
@azumakuniyuki
894fadd Use sisimai/string.Select() for getting a comment from Report…
04e867a 
…ing-MTA field
@azumakuniyuki
Reduce variables
357bbe3
@azumakuniyuki
Code improvement for strings.*
2064f2c
@azumakuniyuki
Reduce variables
dabcf93
@azumakuniyuki
Condition block improvement
c656f6a
@azumakuniyuki
Reduce variables
c37a576
@azumakuniyuki
Fix the comment for sisimai/address.Rise() function
e7266ab
@azumakuniyuki
Variable scope improvement
35aba8c
@azumakuniyuki
Loop and variable scope improvement
0496e84
@azumakuniyuki
Use strings.Replace() in the loop
0f82663
@azumakuniyuki
Loop and variable scope improvements in lhost/via-*.go
b38191f
@azumakuniyuki
Loop and variable scope improvements in message/
a4b9b5b
@azumakuniyuki
Use if {} instead of for {}
8927e8c
@azumakuniyuki
if conditions improvement
bd4a628
@azumakuniyuki
Variable scope improvement
042775b
@azumakuniyuki
Remove for{} loop, return as soon as possible in rfc2045.IsEncoded()
08d8602
@azumakuniyuki
Variables improvement in rfc2045.DecodeH()
f35091e
@azumakuniyuki
Immediately return when the argument is empty at rfc2045.DecodeH()
8207868
@azumakuniyuki
Variable names, scopes, and loop blocks improved
431bbd3
@azumakuniyuki
Variable names, scopes, and other code improvements
a9bfb2f
@codecov Codecov
Copy link

codecov bot commented Feb 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 34.88372% with 196 lines in your changes missing coverage. Please review.

Project coverage is 56.67%. Comparing base (9f78b76) to head (a9bfb2f).
Report is 50 commits behind head on master.

Files with missing lines Patch % Lines
lhost/via-exim.go 0.00% 25 Missing ⚠️
lhost/via-postfix.go 0.00% 14 Missing ⚠️
lhost/via-googleworkspace.go 0.00% 13 Missing ⚠️
lhost/via-messagingserver.go 0.00% 10 Missing ⚠️
lhost/via-gmail.go 0.00% 8 Missing ⚠️
lhost/via-mailfoundry.go 0.00% 7 Missing ⚠️
rfc2045/make-multipart-flat.go 75.00% 4 Missing and 3 partials ⚠️
lhost/via-notes.go 0.00% 6 Missing ⚠️
lhost/via-exchange2003.go 0.00% 5 Missing ⚠️
lhost/via-ezweb.go 0.00% 5 Missing ⚠️
... and 40 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   56.05%   56.67%   +0.62%     
==========================================
  Files         145      145              
  Lines       12180    11966     -214     
==========================================
- Hits         6827     6782      -45     
+ Misses       5004     4848     -156     
+ Partials      349      336      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azumakuniyuki azumakuniyuki added enhancement New feature or request improvement Code improvements labels Feb 15, 2025
@azumakuniyuki azumakuniyuki merged commit a608be5 into master Feb 15, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request improvement Code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@azumakuniyuki