Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added lost datapoints from graphql migration #199

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eekpo1
Copy link

@eekpo1 eekpo1 commented Feb 7, 2025

Description of change

During the migration of the deprecated rest API for the product and inventory items streams, the initial schemas for the graphql streams had omitted some fields. This PR will add in the omitted fields back using their updated aliases in the shopify product_variant graphql endpoint:

  • weight -> inventoryItem.measurement.weight.(unit|value)
  • fulfillment_service -> inventoryItem.inventoryLevel.location.fulfillmentService.handle

QA steps

  • [ x] manual qa steps passing (list below)
    • discovery and sync successful with new fields marked as available

Risks

graphql mapping names not properly spelled, thus returning null values or errors based on field name.

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant