Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flexidate #112

Closed
wants to merge 2 commits into from
Closed

Conversation

ivanovyordan
Copy link

Description of change

Fix #94
Flexidate is a date parser that works well with dates not supported by Python's built-in datetime package.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
  1. Insert 3 records with 3 different date values - todays date, a BC date and a date in year 10000.
  2. Start the initial sync
  3. Insert 3 new records with similiar dates
  4. Start incremental sync
  5. Check the values in the target

Risks

The target needs to handle these dates properly otherwise, there will be a similar error.

Rollback steps

  • revert this branch

Flexidate is a date parser that works well with date that out of
Python's built-in datetime package.
@ivanovyordan ivanovyordan deleted the fix-dates-parsing branch November 18, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum date range not supported
1 participant