DEVEXP-469: Support sms versioning #26
Conversation
JPPortier
requested review from
Dovchik,
krogers0607 and
asein-sinch
as code owners
|
|
||
| // let business layer process the request | ||
| switch (event) { | ||
| case InboundText e -> webhooksBusinessLogic.processInboundEvent(e); | ||
| case TextMessage e -> webhooksBusinessLogic.processInboundEvent(e); | ||
| default -> throw new IllegalStateException("Unexpected value: " + event); |
There was a problem hiding this comment.
Maybe we can imagine to respond successfully in case of a Delivery Report event, even if we don't use it in this getting-started example. Otherwise, the server will be flooded with attempts from the Sinch server to deliver this event successfully.
There was a problem hiding this comment.
🤔
We can discuss furthermore, because on the opposite, responding silently and blindly "that's fine" to every request may be not the best onboarding and quickstart way we could want for a Sinch product (e.g Verification even if I'm aware we are having different Controllers int this current sample app).
So finally, do we want to highlight to end users to take aware of their own backend with exception/error logs (they should monitoring) to do we want to avoid them to be flood because they do not handle "properly" webhooks management.
It seems my answer give insight about my preference 👼 but open to discussion 😄
No description provided.