Set no diagonal balance when reading UBC tree meshes #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set `diagonal_balance=False` when creating a TreeMesh after reading a UBC file in `read_UBC`. This prevents raising the future warning related to the default value of `diagonal_balance`. Add test that checks that no warning is being raised by that method.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
+ Coverage 86.19% 86.21% +0.01%
==========================================
Files 90 90
Lines 18609 18616 +7
Branches 2103 2103
==========================================
+ Hits 16040 16049 +9
+ Misses 1884 1883 -1
+ Partials 685 684 -1 ☔ View full report in Codecov by Sentry. |
jcapriot
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
diagonal_balance=Falsewhen creating aTreeMeshafter reading a UBC file inread_UBC. This prevents raising the future warning related to the default value ofdiagonal_balance. Add test that checks that no warning is being raised by that method.