-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/1246 allow reordering complex form components #1385
Merged
myieye
merged 15 commits into
develop
from
feat/1246-allow-reordering-complex-form-components
Feb 12, 2025
Merged
Feat/1246 allow reordering complex form components #1385
myieye
merged 15 commits into
develop
from
feat/1246-allow-reordering-complex-form-components
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a299fa5
to
de7e10e
Compare
hahn-kev
reviewed
Jan 20, 2025
hahn-kev
reviewed
Jan 20, 2025
hahn-kev
reviewed
Jan 20, 2025
hahn-kev
reviewed
Jan 20, 2025
hahn-kev
reviewed
Jan 20, 2025
…es, even after they are modified
…mplementation for IOrderableCollectionDiffApi.GetId
…d a comment in the file documenting its purpose
…ordering-complex-form-components
hahn-kev
reviewed
Feb 12, 2025
hahn-kev
reviewed
Feb 12, 2025
hahn-kev
reviewed
Feb 12, 2025
hahn-kev
reviewed
Feb 12, 2025
hahn-kev
reviewed
Feb 12, 2025
…ordering-complex-form-components
hahn-kev
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
ComplexEntryComponent
s, so that I didn't need to makeBetweenPosition
generic. You actually only need 1 Guid. If you're comparing complex-forms then you can use the complex-form ID. If you're comparing components then you usecomponentSenseId ?? componentEntryId
, so you get the most specific one.For CRDTs it can be mapped back to theComplexEntryComponent.Id
before entering the API.I addedGetDataFormat()
to the MiniLcmApi in order to distinguish the two cases ☝️ComplexFormComponent
objects, so the don't need to differentiate and the implementations have everything they needCanInsertComplexFormComponentViaSync
proved to be a super valuable test. What cases passed and failed changed constantly as I was fleshing out the Fw implementation.