Skip to content

Commit

Permalink
Bump PNPM to 9.15.5 (#1440)
Browse files Browse the repository at this point in the history
* Bump PNPM to 9.15.5

PNPM v9.15.5 brings in several bugfixes, at least one of which (running
preprepare scripts from packages on pnpm install, and "preprepare" is
not a typo) we'll probably want to have when we upgrade our SvelteKit
dependency.

* Prep for PNPM 10: add "prepare": "svelte-kit sync"
* Work around corepack bug preventing PNPM install
  • Loading branch information
rmunn authored Feb 13, 2025
1 parent 36679d8 commit d4cc7cb
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 3 deletions.
2 changes: 2 additions & 0 deletions frontend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# TODO: can't use vanilla alpine version since python is needed for gql-codegen stuff.
FROM node:20 AS builder-base
WORKDIR /app
# Version of corepack distributed with node currently (2025-02-04) has a bug that prevents PNPM installation; latest version has the bugfix
RUN npm install -g corepack@latest
RUN corepack enable && corepack prepare pnpm@9.11.0 --activate

FROM builder-base AS builder-viewer
Expand Down
2 changes: 2 additions & 0 deletions frontend/dev.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# TODO: can't use vanilla alpine version since python is needed for gql-codegen stuff.
FROM node:20 AS builder

# Version of corepack distributed with node currently (2025-02-04) has a bug that prevents PNPM installation; latest version has the bugfix
RUN npm install -g corepack@latest
RUN corepack enable && corepack prepare pnpm@9.11.0 --activate
WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion frontend/https-proxy/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "https-proxy",
"version": "0.0.1",
"private": true,
"packageManager": "pnpm@9.11.0",
"packageManager": "pnpm@9.15.5",
"engines": {
"node": ">=20",
"pnpm": ">=9"
Expand Down
3 changes: 2 additions & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@
"name": "frontend",
"version": "0.0.1",
"private": true,
"packageManager": "pnpm@9.11.0",
"packageManager": "pnpm@9.15.5",
"engines": {
"node": ">=20",
"pnpm": ">=9"
},
"scripts": {
"dev": "vite dev",
"lexbox-dev": "vite dev --port 3000 --host 0.0.0.0",
"prepare": "svelte-kit sync",
"build": "vite build",
"preview": "vite preview",
"pretest": "playwright install",
Expand Down
2 changes: 1 addition & 1 deletion frontend/viewer/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "viewer",
"private": true,
"packageManager": "pnpm@9.11.0",
"packageManager": "pnpm@9.15.5",
"engines": {
"node": ">=20",
"pnpm": ">=9"
Expand Down

0 comments on commit d4cc7cb

Please sign in to comment.