Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Support? #149

Open
rlingineni opened this issue Mar 14, 2019 · 5 comments
Open

Typescript Support? #149

rlingineni opened this issue Mar 14, 2019 · 5 comments

Comments

@rlingineni
Copy link

Planning on making this library typescript and as a common interface so that everything is supported. I looked at a lot of other ones, and this is the cleanest and most friendly to extend. I could do some cleaning up. I can also update to ES6 syntax with async/await - for at least a few of the ones I can do.

It wouldn't change the main repo other than the fact that you'll have a new ts folder.

Are you guys ok with that? Or should I go ahead with my own fork and develop separately. Namely looking to clean up S3 and Github - because that's what I need for my larger project for now.

@JbIPS
Copy link
Collaborator

JbIPS commented Mar 14, 2019

Hello @rlingineni,

I was planning to drop Bluebird for async/await but I won't mind if you do it 😃. For TypeScript, do you plan on only writing the types (to import it in TS codebase) or rewrite the whole thing in TS?

For those 2 things, we need to think retro-compatibility. For ES6, we'll do a new major version. And for TS, well, that will depends on your goal!

Anyway, very excited to hear about that and I'll help you in anyway I can.

Thank you

@lexoyo
Copy link
Member

lexoyo commented Mar 14, 2019

👍 for typescript types and S3
I'd use them in Silex

@lexoyo
Copy link
Member

lexoyo commented Mar 31, 2019

Hi @rlingineni
I am 90% done with porting Silex to typescript (getting ridd of google closure, splitting silex in smaller projects)
Do you need help for the typing?

@rlingineni
Copy link
Author

Hey @lexoyo , I was working on a project which had this dependency, but it got abandoned. If I have time in the future, I will definitely revisit this. I'm sorry to have raised hopes here

@lexoyo
Copy link
Member

lexoyo commented Mar 31, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants