Fix jsone:try_encode({{json_utf8, IncompleteUtf8}}) raises a try_clause exception.
#81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code:characters_to_binary/1`
sile
changed the title
jsone:try_encode({{json_utf8, IncompleteUtf8}}) raises an try_clause exception.jsone:try_encode({{json_utf8, IncompleteUtf8}}) raises a try_clause exception.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 91.91% 92.23% +0.32%
==========================================
Files 4 4
Lines 334 335 +1
==========================================
+ Hits 307 309 +2
+ Misses 27 26 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{jsone_utf8, _}}feature was introduced in #11, but it turned out that the current implementation doesn't consider thatunicode:characters_to_binary/1could return{incomplete, _, _}tuple as the result.If the tuple is returned,
try_encode()method raises an (unintended) exception.This PR fixes this problem.