Merge pull request #118 from silarhi/app-update

upgrade rector and phpstan

composer.json

@@ -10,8 +10,8 @@
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^3.65",
         "phpunit/phpunit": "^10.5.20|^11.1.3",
-        "phpstan/phpstan": "^1.12.7",
-        "rector/rector": "^1.2",
+        "phpstan/phpstan": "^2",
+        "rector/rector": "^2",
         "vimeo/psalm": "^5.26",
         "doctrine/data-fixtures": "^2.0",
         "symfony/cache": "^7.0"

phpstan.dist.neon

@@ -3,3 +3,5 @@ parameters:
 	paths:
 		- src
 		- tests
+	ignoreErrors:
+		- message: "#^Property Silarhi\\\\CursorPagination\\\\Tests\\\\Entity\\\\.*\\:\\:\\$id \\(int\\|null\\) is never assigned int so it can be removed from the property type\\.$#"

src/Pagination/CursorPagination.php

@@ -38,6 +38,7 @@ final class CursorPagination implements IteratorAggregate, Countable
     /** @var array<int|string, mixed> */
     private array $afterValues = [];
 
+    /** @var int<0, max>|null */
     private ?int $nbResults = null;
 
     public function __construct(

tests/Pagination/CursorPaginationTest.php

@@ -195,8 +195,11 @@ private function getSimpleCursorPagination(): CursorPagination
             ->getRepository(User::class)
             ->createQueryBuilder('u');
 
-        return new CursorPagination($queryBuilder, new OrderConfigurations(
+        /** @var CursorPagination<User> $pagination */
+        $pagination = new CursorPagination($queryBuilder, new OrderConfigurations(
             new OrderConfiguration('u.id', fn (User $user) => $user->getId()),
         ), 2);
+
+        return $pagination;
     }
 }