Update Sigstore Timestamp using dependabot #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexis <alexis.challande@trailofbits.com>
DarkaMaul
commented
Nov 26, 2024
.github/workflows/ci.yml
Outdated
| @@ -61,7 +61,8 @@ jobs: | |||
| - name: test (timestamp-authority) | |||
| if: ${{ matrix.conf.os == 'ubuntu-latest' }} | |||
| run: | | |||
| wget https://github.com/sigstore/timestamp-authority/releases/download/${SIGSTORE_TIMESTAMP}/timestamp-server-linux-amd64 -O /tmp/timestamp-server | |||
| export SIGSTORE_TIMESTAMP_VERSION=$(grep "github.com/sigstore/timestamp-authority" .github/go.mod | awk '{print $2}') | |||
There was a problem hiding this comment.
FLAG: I'm unsure of the implications here - is this a dangerous pattern in a workflow ?
There was a problem hiding this comment.
looks ok to me.
export seems unnecessary though
jku
reviewed
Nov 26, 2024
.github/workflows/ci.yml
Outdated
| @@ -61,7 +61,8 @@ jobs: | |||
| - name: test (timestamp-authority) | |||
| if: ${{ matrix.conf.os == 'ubuntu-latest' }} | |||
| run: | | |||
| wget https://github.com/sigstore/timestamp-authority/releases/download/${SIGSTORE_TIMESTAMP}/timestamp-server-linux-amd64 -O /tmp/timestamp-server | |||
| export SIGSTORE_TIMESTAMP_VERSION=$(grep "github.com/sigstore/timestamp-authority" .github/go.mod | awk '{print $2}') | |||
There was a problem hiding this comment.
looks ok to me.
export seems unnecessary though
Signed-off-by: Alexis <alexis.challande@trailofbits.com>
Signed-off-by: Alexis <alexis.challande@trailofbits.com>
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up from #1216 and update (Sigstore) Timestamp Authority to be picked up by dependabot ( following a comment from @woodruffw )
I've tested the approach at https://github.com/DarkaMaul/test-dep, and that appears to be working.