Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support cryptography-44 #1250

Closed
mgorny opened this issue Dec 11, 2024 · 5 comments · Fixed by #1263
Closed

Please support cryptography-44 #1250

mgorny opened this issue Dec 11, 2024 · 5 comments · Fixed by #1263
Labels
enhancement New feature or request

Comments

@mgorny
Copy link

mgorny commented Dec 11, 2024

Description

Please add support for cryptography-44. Right now, sigstore is the only package on Gentoo systems that prevents upgrade to the newer cryptography version.

@mgorny mgorny added the enhancement New feature or request label Dec 11, 2024
@jku
Copy link
Member

jku commented Dec 11, 2024

requires #1235, #1233, #1246

@jku
Copy link
Member

jku commented Dec 11, 2024

requires #1235, #1233, #1246

These should be handled now: Unfortunately because of the rfc3161-client upgrade we also now effectively require cryptography>=44 in main and in next release.

@woodruffw should we document this 44 requirement in pyproject or do something else about this? Strictly speaking we don't require any 44 API ourselves but it feels like this could be an annoying switch of a major dependency over a single release (current releases only supports < 44, next release only supports >=44)

@mgorny
Copy link
Author

mgorny commented Dec 11, 2024

Thanks.

@woodruffw
Copy link
Member

@woodruffw should we document this 44 requirement in pyproject or do something else about this? Strictly speaking we don't require any 44 API ourselves but it feels like this could be an annoying switch of a major dependency over a single release (current releases only supports < 44, next release only supports >=44)

Yeah, documenting it makes sense -- we've done similar major dep bumps of cryptography in prior releases without too much trouble, so I think a note should be sufficient.

Alternatively I think we could support >= 43, < 45 within rfc3161-client without too much effort -- CC @DarkaMaul for thoughts there.

@woodruffw
Copy link
Member

#1263 will fully resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants