Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade scaffolding to v0.7.2 #1488

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

malancas
Copy link
Contributor

@malancas malancas commented Jun 17, 2024

Summary

Upgrade scaffolding to v0.7.2 in the Kind related workflows. This will resolve the metallb related errors we are seeing in the Kind testing workflows.

Release Note

Documentation

@malancas
Copy link
Contributor Author

malancas commented Jun 17, 2024

cc @hectorj2f @vaikas just wanted to let you both know

@vaikas
Copy link
Collaborator

vaikas commented Jun 18, 2024

Looks like 7.2 was cut? Can we try with that?

@vaikas
Copy link
Collaborator

vaikas commented Jun 18, 2024

Looks like both tests failed with expired TUF root 🤔

--- FAIL: TestClientFromSerializedMirror (0.00s)
    repo_test.go:206: Failed to unserialize repo: failed to update TUF client: tuf: failed to decode root.json: expired at 2024-06-14 18:52:45 +0000 UTC

@malancas malancas changed the title Temporarily use main instead of v0.7.1 as scaffolding version to test Kind workflow related issue Upgrade scaffolding version to v0.7.2 Jun 18, 2024
@malancas
Copy link
Contributor Author

Looks like 7.2 was cut? Can we try with that?

Perfect timing, just updated to 7.2

@malancas malancas marked this pull request as ready for review June 18, 2024 14:02
@malancas malancas changed the title Upgrade scaffolding version to v0.7.2 Upgrade scaffolding to v0.7.2 Jun 18, 2024
@vaikas
Copy link
Collaborator

vaikas commented Jun 18, 2024

Looks like it failed again, haha, looks like the testdata needs to be recreated:

// IMPORTANT: The next expiration is on '2024-06-14T18:52:45Z'

@malancas
Copy link
Contributor Author

Throwing this back into draft while I work on the other test failures.

@malancas malancas marked this pull request as draft June 18, 2024 17:08
@hectorj2f
Copy link
Collaborator

@malancas Do you know how to fix the tuf expiration ? Otherwise I can take some time tomorrow morning to fix it.

@malancas
Copy link
Contributor Author

@malancas Do you know how to fix the tuf expiration ? Otherwise I can take some time tomorrow morning to fix it.

I don't think so. I'll remove the initial TUF changes from this PR and just let this update the scaffolding version if you have time to work on the TUF expiration.

@malancas malancas marked this pull request as ready for review June 18, 2024 17:34
@malancas malancas force-pushed the use-current-scaffolding-version branch from 2761566 to f6ba46f Compare June 18, 2024 17:43
@hectorj2f
Copy link
Collaborator

@malancas You could cherry pick my changes from here #1496 if you prefer.

malancas added 3 commits June 19, 2024 10:25
… workflow issue

Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
@cpanato cpanato force-pushed the use-current-scaffolding-version branch from f6ba46f to 1351172 Compare June 19, 2024 08:26
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.28%. Comparing base (50ef092) to head (1351172).
Report is 98 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1488       +/-   ##
===========================================
- Coverage   52.92%   42.28%   -10.65%     
===========================================
  Files          44      121       +77     
  Lines        3979     7168     +3189     
===========================================
+ Hits         2106     3031      +925     
- Misses       1651     3783     +2132     
- Partials      222      354      +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpanato
Copy link
Member

cpanato commented Jun 19, 2024

thanks @malancas for the fix! i did a rebase to unblock ci and we were able to merge the other PRs in the queue, hope you dont mind

@cpanato cpanato merged commit d7ae1a6 into sigstore:main Jun 19, 2024
70 of 71 checks passed
@github-actions github-actions bot added this to the v1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants