-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade scaffolding to v0.7.2 #1488
Upgrade scaffolding to v0.7.2 #1488
Conversation
cc @hectorj2f @vaikas just wanted to let you both know |
Looks like 7.2 was cut? Can we try with that? |
Looks like both tests failed with expired TUF root 🤔
|
main
instead of v0.7.1
as scaffolding version to test Kind workflow related issue
Perfect timing, just updated to 7.2 |
Looks like it failed again, haha, looks like the testdata needs to be recreated: policy-controller/pkg/tuf/repo_test.go Line 73 in f099546
|
Throwing this back into draft while I work on the other test failures. |
@malancas Do you know how to fix the tuf expiration ? Otherwise I can take some time tomorrow morning to fix it. |
I don't think so. I'll remove the initial TUF changes from this PR and just let this update the scaffolding version if you have time to work on the TUF expiration. |
2761566
to
f6ba46f
Compare
… workflow issue Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
f6ba46f
to
1351172
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1488 +/- ##
===========================================
- Coverage 52.92% 42.28% -10.65%
===========================================
Files 44 121 +77
Lines 3979 7168 +3189
===========================================
+ Hits 2106 3031 +925
- Misses 1651 3783 +2132
- Partials 222 354 +132 ☔ View full report in Codecov by Sentry. |
thanks @malancas for the fix! i did a rebase to unblock ci and we were able to merge the other PRs in the queue, hope you dont mind |
Summary
Upgrade scaffolding to
v0.7.2
in the Kind related workflows. This will resolve the metallb related errors we are seeing in the Kind testing workflows.Release Note
Documentation