Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump github.com/hashicorp/go-sockaddr from 1.0.5 to 1.0.6 #1086

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 13, 2023

Bumps github.com/hashicorp/go-sockaddr from 1.0.5 to 1.0.6.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (532516e) 54.69% compared to head (127d6c1) 54.69%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1086   +/-   ##
=======================================
  Coverage   54.69%   54.69%           
=======================================
  Files          44       44           
  Lines        4841     4841           
=======================================
  Hits         2648     2648           
  Misses       1977     1977           
  Partials      216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hectorj2f
Copy link
Collaborator

@dependabot rebase

Bumps [github.com/hashicorp/go-sockaddr](https://github.com/hashicorp/go-sockaddr) from 1.0.5 to 1.0.6.
- [Commits](hashicorp/go-sockaddr@v1.0.5...v1.0.6)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-sockaddr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/hashicorp/go-sockaddr-1.0.6 branch from efe1dfd to 5f0b319 Compare November 16, 2023 09:22
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
@hectorj2f hectorj2f enabled auto-merge November 20, 2023 20:28
@hectorj2f hectorj2f requested a review from cpanato November 20, 2023 20:28
@@ -1,5 +1,12 @@
package sockaddr

import "errors"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it bringing in go code in the LICENSE directories?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check if there is anything broken. But it is weird too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at the content of third-party and I found it already contained go files in https://github.com/sigstore/policy-controller/blob/main/third_party/VENDOR-LICENSE/github.com/letsencrypt/boulder/core/challenges.go

@hectorj2f hectorj2f requested a review from vaikas November 23, 2023 21:16
@hectorj2f hectorj2f merged commit a9936d0 into main Nov 24, 2023
76 checks passed
@hectorj2f hectorj2f deleted the dependabot/go_modules/github.com/hashicorp/go-sockaddr-1.0.6 branch November 24, 2023 06:53
@github-actions github-actions bot added this to the v1 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants