Skip to content

Control the policy controller monitoring resources from chart, enhanc… #2696

Control the policy controller monitoring resources from chart, enhanc…

Control the policy controller monitoring resources from chart, enhanc… #2696

Re-run triggered December 17, 2024 16:51
Status Failure
Total duration 44s
Artifacts 1

style.yaml

on: pull_request
check gofmt
11s
check gofmt
check goimports
19s
check goimports
Fit to window
Zoom out
Zoom in

Annotations

5 errors
check gofmt: cmd/webhook/main.go#L1
Please run gofmt -s. diff --git a/cmd/webhook/main.go b/cmd/webhook/main.go index 6e583e2..9ab5897 100644 --- a/cmd/webhook/main.go +++ b/cmd/webhook/main.go @@ -80,11 +80,11 @@ var ( disableTUF = flag.Bool("disable-tuf", false, "Disable TUF support.") // Validate specific resources. - // https://github.com/sigstore/policy-controller/issues/1388 - resourcesNames = flag.String("resource-name", "replicasets, deployments, pods, cronjobs, jobs, statefulsets, daemonsets", "Comma-separated list of resources") - // Split the input string into a slice of strings - listResources []string - types map[schema.GroupVersionKind]resourcesemantics.GenericCRD + // https://github.com/sigstore/policy-controller/issues/1388 + resourcesNames = flag.String("resource-name", "replicasets, deployments, pods, cronjobs, jobs, statefulsets, daemonsets", "Comma-separated list of resources") + // Split the input string into a slice of strings + listResources []string + types map[schema.GroupVersionKind]resourcesemantics.GenericCRD // mutatingCIPWebhookName holds the name of the mutating webhook configuration // resource dispatching admission requests to policy-webhook. @@ -125,7 +125,7 @@ func main() { flag.Parse() resourcesNamesList := strings.Split(*resourcesNames, ",") - listResources = append(listResources, resourcesNamesList...) + listResources = append(listResources, resourcesNamesList...) // If TUF has been disabled do not try to set it up. if !*disableTUF { @@ -300,7 +300,7 @@ func NewMutatingAdmissionController(ctx context.Context, _ configmap.Watcher) *c } ctx = webhook.WithOptions(ctx, *woptions) validator := cwebhook.NewValidator(ctx) - types = createTypesMap(listResources) + types = createTypesMap(listResources) return defaulting.NewAdmissionController(ctx, // Name of the resource webhook. *webhookName,
check gofmt
Process completed with exit code 1.
check goimports: cmd/webhook/main.go#L1
Please run goimports. diff --git a/cmd/webhook/main.go b/cmd/webhook/main.go index 6e583e2..9ab5897 100644 --- a/cmd/webhook/main.go +++ b/cmd/webhook/main.go @@ -80,11 +80,11 @@ var ( disableTUF = flag.Bool("disable-tuf", false, "Disable TUF support.") // Validate specific resources. - // https://github.com/sigstore/policy-controller/issues/1388 - resourcesNames = flag.String("resource-name", "replicasets, deployments, pods, cronjobs, jobs, statefulsets, daemonsets", "Comma-separated list of resources") - // Split the input string into a slice of strings - listResources []string - types map[schema.GroupVersionKind]resourcesemantics.GenericCRD + // https://github.com/sigstore/policy-controller/issues/1388 + resourcesNames = flag.String("resource-name", "replicasets, deployments, pods, cronjobs, jobs, statefulsets, daemonsets", "Comma-separated list of resources") + // Split the input string into a slice of strings + listResources []string + types map[schema.GroupVersionKind]resourcesemantics.GenericCRD // mutatingCIPWebhookName holds the name of the mutating webhook configuration // resource dispatching admission requests to policy-webhook. @@ -125,7 +125,7 @@ func main() { flag.Parse() resourcesNamesList := strings.Split(*resourcesNames, ",") - listResources = append(listResources, resourcesNamesList...) + listResources = append(listResources, resourcesNamesList...) // If TUF has been disabled do not try to set it up. if !*disableTUF { @@ -300,7 +300,7 @@ func NewMutatingAdmissionController(ctx context.Context, _ configmap.Watcher) *c } ctx = webhook.WithOptions(ctx, *woptions) validator := cwebhook.NewValidator(ctx) - types = createTypesMap(listResources) + types = createTypesMap(listResources) return defaulting.NewAdmissionController(ctx, // Name of the resource webhook. *webhookName,
check goimports
Process completed with exit code 1.
check goimports
Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

Artifacts

Produced during runtime
Name Size
diff
905 Bytes