Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tree_hash version, allow SSZ patch updates #40

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

paulhauner
Copy link
Member

Continuing the round-robin of version bumps

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.55%. Comparing base (e867ed5) to head (194947c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files           8        8           
  Lines         270      270           
=======================================
  Hits          150      150           
  Misses        120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! For some reason I failed to consider that we'd need to bump tree_hash here

ethereum_serde_utils = "0.7.0"
ethereum_ssz = "0.8.0"
ethereum_ssz = "0.8"
Copy link
Member

@michaelsproul michaelsproul Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI there's no difference between 0.8.0 and 0.8 version requirements. They both allow semver compatible updates in the patch version (last digit)

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-cratesio

@michaelsproul michaelsproul merged commit e1fef81 into main Dec 20, 2024
7 checks passed
@michaelsproul michaelsproul deleted the bump-th-ssz branch December 20, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants