Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bitfield #28

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Remove Bitfield #28

merged 3 commits into from
Dec 4, 2024

Conversation

macladson
Copy link
Member

@macladson macladson commented Jul 26, 2024

In preparation for EIP-7495, Bitfield has been moved to the ethereum_ssz crate.

This PR removes it and simply re-exports it from the ethereum_ssz crate.

Relevant PR: sigp/ethereum_ssz#25

Cargo.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.19%. Comparing base (9e59ff9) to head (8b8cf14).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   61.16%   54.19%   -6.97%     
==========================================
  Files           9        8       -1     
  Lines         497      262     -235     
==========================================
- Hits          304      142     -162     
+ Misses        193      120      -73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@macladson
Copy link
Member Author

Now that sigp/ethereum_ssz#25 is merged, we just need a release, then I can update this PR to refer to it.

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelsproul michaelsproul merged commit 2b01793 into sigp:main Dec 4, 2024
6 of 7 checks passed
paulhauner added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants