Fix misc PeerDAS todos #6862
Open
Fix misc PeerDAS todos #6862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the inclusion proof check plus kzg checks ensure that they are correct
… in report_rpc_response_errors
dapplion
added
work-in-progress
dapplion
commented
Jan 24, 2025
| @@ -182,8 +173,7 @@ impl<E: EthSpec> PendingComponents<E> { | |||
| kzg_verified_data_columns: I, | |||
| ) -> Result<(), AvailabilityCheckError> { | |||
| for data_column in kzg_verified_data_columns { | |||
| // TODO(das): Add equivalent checks for data columns if necessary | |||
| if !self.data_column_exists(data_column.index()) { | |||
| if self.get_cached_data_column(data_column.index()).is_none() { | |||
There was a problem hiding this comment.
Checks not necessary, we check the inclusion proof both via RPC and gossip. Inlined the function as it makes it easier to follow what's actually doing the data_column_exists check
| @@ -753,7 +752,6 @@ impl TestRig { | |||
| } | |||
|
|
|||
| // Expect work event | |||
| // TODO(das): worth it to append sender id to the work event for stricter assertion? | |||
There was a problem hiding this comment.
Not needed, there's a single request in this test
dapplion
commented
Jan 25, 2025
| peer_id, | ||
| PeerAction::MidToleranceError, | ||
| "blob_not_required", | ||
| ); |
There was a problem hiding this comment.
Implemented the penalty, all implementations should not send blobs by now @jimmygchen
| let delay = get_slot_delay_ms(seen_timestamp, slot, &self.chain.slot_clock); | ||
| metrics::observe_duration(&metrics::BEACON_BLOB_RPC_SLOT_START_DELAY_TIME, delay); | ||
| } | ||
| } |
There was a problem hiding this comment.
Use seen_timestamp is the same metric for blobs. Should we generalize the name?
| @@ -102,8 +103,6 @@ impl<T: BeaconChainTypes> ActiveCustodyRequest<T> { | |||
| resp: RpcResponseResult<DataColumnSidecarList<T::EthSpec>>, | |||
| cx: &mut SyncNetworkContext<T>, | |||
| ) -> CustodyRequestResult<T::EthSpec> { | |||
| // TODO(das): Should downscore peers for verify errors here | |||
There was a problem hiding this comment.
No, verify errors are handled in network_context.rs and downscored there
dapplion
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Address misc PeerDAS TODOs that are not too big for a dedicated PR
Proposed Changes
I'll justify each TODO on an inlined comment