Implement PeerDAS Fulu fork activation #6795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
force-pushed
the
jimmy/lh-2271-activate-peerdas-at-fulu-fork-and-remove-eip7594_fork_epoch
branch
from
c1b0c91 to
2082c92
Compare
jimmygchen
force-pushed
the
jimmy/lh-2271-activate-peerdas-at-fulu-fork-and-remove-eip7594_fork_epoch
branch
from
2082c92 to
b029342
Compare
jimmygchen
commented
Jan 13, 2025
jimmygchen
commented
Jan 13, 2025
jimmygchen
commented
Jan 13, 2025
dapplion
reviewed
Jan 14, 2025
jimmygchen
added
waiting-on-author
…ivate-peerdas-at-fulu-fork-and-remove-eip7594_fork_epoch # Conflicts: # beacon_node/lighthouse_network/src/rpc/protocol.rs # testing/ef_tests/check_all_files_accessed.py # testing/ef_tests/src/handler.rs
jimmygchen
added
ready-for-review
jimmygchen
force-pushed
the
jimmy/lh-2271-activate-peerdas-at-fulu-fork-and-remove-eip7594_fork_epoch
branch
3 times, most recently
from
d188403 to
11e9e13
Compare
…kurtosis config for PeerDAS as electra genesis is not yet supported.
jimmygchen
force-pushed
the
jimmy/lh-2271-activate-peerdas-at-fulu-fork-and-remove-eip7594_fork_epoch
branch
from
11e9e13 to
8cdf82e
Compare
jimmygchen
added
waiting-on-author
…ivate-peerdas-at-fulu-fork-and-remove-eip7594_fork_epoch # Conflicts: # beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs # consensus/types/src/chain_spec.rs # testing/ef_tests/src/cases.rs # testing/ef_tests/src/cases/get_custody_groups.rs # testing/ef_tests/src/cases/kzg_compute_cells_and_kzg_proofs.rs # testing/ef_tests/src/cases/kzg_recover_cells_and_kzg_proofs.rs # testing/ef_tests/src/cases/kzg_verify_cell_kzg_proof_batch.rs # testing/ef_tests/src/handler.rs # testing/ef_tests/tests/tests.rs
dapplion
approved these changes
Jan 16, 2025
|
Release tests are failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses #6706
Proposed Changes
This PR activates PeerDAS at the Fulu fork epoch instead of
EIP_7594_FORK_EPOCH. This means we no longer support testing PeerDAS with Deneb / Electrs, as it's now part of a hard fork.The spec tests are currently disabled as the tests are being updated in #6736.
Note: this PR also switches Fulu to use
*_payload_v4engine methods, as the v5 are not yet implemented, we should revert this commit once we're ready to switch over (I've addTODO(fulu)comments to the changes): 8cdf82e