Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP-7636 support #6793

Open
wants to merge 5 commits into
base: unstable
Choose a base branch
from
Open

Add EIP-7636 support #6793

wants to merge 5 commits into from
+34 −1

Conversation

JKincorperated
Copy link

Proposed Changes

This adds the option to self-report EIP-7636 information

Additional Info

This defaults to true as the reported information should not cause any issues.

@JKincorperated JKincorperated requested a review from jxs as a code owner January 11, 2025 11:42
@michaelsproul
Copy link
Member

I think github remembers the branch and doesn't re-run CI. Try amending your commit or pushing an empty commit with git commit --allow-empty

ackintosh
ackintosh reviewed Jan 12, 2025
View reviewed changes
Copy link
Member

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding some functions (like version(), build_version()) to the lighthouse_version crate and using these functions at enr.rs would be a good option to ensure the correct version info is obtained.

beacon_node/lighthouse_network/src/discovery/enr.rs Outdated Show resolved Hide resolved
beacon_node/lighthouse_network/src/discovery/enr.rs Outdated Show resolved Hide resolved
@michaelsproul michaelsproul added enhancement New feature or request Networking labels Jan 12, 2025
ackintosh
ackintosh approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. It looks good to me. 🙏

michaelsproul
michaelsproul approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label Jan 15, 2025
@michaelsproul
Copy link
Member

Looks like cargo fmt needs to be run to fix formatting @JKincorperated

Then we can merge!

@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@ackintosh ackintosh ackintosh approved these changes

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request Networking waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JKincorperated @michaelsproul @ackintosh