Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.84 lints #6781

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Rust 1.84 lints #6781

merged 3 commits into from
Jan 10, 2025

Conversation

pawanjay176
Copy link
Member

@pawanjay176 pawanjay176 commented Jan 10, 2025

Issue Addressed

N/A

Proposed Changes

Fix all lints from rust 1.84.

Verified

This commit was signed with the committer’s verified signature.
pawanjay176 Pawan Dhananjay

Verified

This commit was signed with the committer’s verified signature.
pawanjay176 Pawan Dhananjay

Verified

This commit was signed with the committer’s verified signature.
pawanjay176 Pawan Dhananjay
@pawanjay176 pawanjay176 requested a review from jxs as a code owner January 10, 2025 00:29
@@ -57,7 +57,7 @@ impl FromStr for GraffitiString {
type Err = String;

fn from_str(s: &str) -> Result<Self, Self::Err> {
if s.as_bytes().len() > GRAFFITI_BYTES_LEN {
if s.len() > GRAFFITI_BYTES_LEN {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is interesting. String length is in bytes, so makes sense:

https://doc.rust-lang.org/std/primitive.str.html#method.len

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i was confused as well, but the lint explicitly stated that they are equivalent

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pawan!

@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label Jan 10, 2025
@michaelsproul
Copy link
Member

Going to try merging this in the same batch as:

@michaelsproul
Copy link
Member

@mergify queue

Copy link

mergify bot commented Jan 10, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 1f6850f

mergify bot added a commit that referenced this pull request Jan 10, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mergify mergify bot merged commit 1f6850f into sigp:unstable Jan 10, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants