-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new features to mergify config #6597
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May need to change the target branch to unstable? |
Hi Ck, since this affects CI needs to be merged against |
jxs
force-pushed
the
improve-mergify
branch
2 times, most recently
from
January 15, 2025 15:56
ab80779
to
660c433
Compare
conditions: | ||
- base=master | ||
- label=trivial | ||
- author=@sigp/lighthouse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created this team.
michaelsproul
approved these changes
Jan 22, 2025
michaelsproul
added
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
labels
Jan 22, 2025
jimmygchen
reviewed
Jan 22, 2025
jimmygchen
reviewed
Jan 22, 2025
jimmygchen
reviewed
Jan 22, 2025
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
While addressing an issue on the rust-libp2p
mergify.yml
config file, finally had time to read its doc and suggest some nice things it has there to the lighthouse repo:add-to-queue
label instead of having to reply to the PR with "@Mergifyio queue"trivial
labelNotes
lighthouse
team doesn't exist yet, we can create it or use thesigp
team which has all its members