Add CLI flag for HTTP API token path (VC) #6577

syjn99 · 2024-11-09T03:12:14Z

Issue Addressed

#6563

Proposed Changes

Added http-token-path flag for users who want to set the token path explicity.
Added documentation for CLI reference, etc.

Additional Info

Throw error when http-token-path is actually a directory.
If parent directory doesn't exist, make parent directory.

CLAassistant · 2024-11-09T03:12:20Z

All committers have signed the CLA.

michaelsproul

Thanks for the pull request!

This looks good on the whole, just a few minor tweaks and then we can merge

validator_client/src/cli.rs

validator_client/src/config.rs

syjn99 · 2024-11-18T10:32:15Z

@michaelsproul
Fixed things you mentioned! Sorry for delay, enjoyed Devcon a lot 🙇‍♂️

chong-he

Did some manual testing and it works well!

book/src/help_vc.md

Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>

syjn99 · 2024-11-24T06:50:07Z

@michaelsproul @chong-he
Could you please check this one more time? I applied reviews, fixed things that broke CI jobs.

syjn99 · 2024-12-03T11:24:24Z

@michaelsproul It seems that there are some flaky tests for make test-network. I'm not sure but it might be related to #6646.

jimmygchen

Looks good to me, thanks for the PR!

jimmygchen · 2024-12-16T04:33:49Z

@mergify queue

mergify · 2024-12-16T04:34:08Z

queue

🛑 The pull request has been removed from the queue `default`

Pull request #6577 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

michaelsproul · 2024-12-16T04:34:47Z

@mergify dequeue

mergify · 2024-12-16T04:34:51Z

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #6577 has been dequeued by a dequeue command.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

mergify · 2024-12-16T04:34:52Z

dequeue

✅ The pull request has been removed from the queue `default`

jimmygchen · 2024-12-16T04:48:49Z

@mergify requeue

mergify · 2024-12-16T04:49:08Z

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

mergify · 2024-12-16T04:49:10Z

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 11e1d5b

Add cli flag for HTTP API token path (VC)

6e8ebc3

syjn99 added 3 commits November 10, 2024 14:09

Add http_token_path_flag test

d987646

Add pre-check for directory case & Fix test utils

43d9423

Update docs

b6beb64

syjn99 changed the title ~~[WIP] Add cli flag for HTTP API token path (VC)~~ Add cli flag for HTTP API token path (VC) Nov 10, 2024

syjn99 changed the title ~~Add cli flag for HTTP API token path (VC)~~ Add CLI flag for HTTP API token path (VC) Nov 10, 2024

syjn99 marked this pull request as ready for review November 10, 2024 06:00

michaelsproul requested changes Nov 14, 2024

View reviewed changes

validator_client/src/cli.rs Outdated Show resolved Hide resolved

validator_client/src/config.rs Outdated Show resolved Hide resolved

michaelsproul added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Nov 15, 2024

syjn99 added 3 commits November 18, 2024 17:18

Apply review: move http_token_path into validator_http_api config

f3ace93

Lint

d7eb3f1

Make diff lesser to replace PK_FILENAME

aa69651

Merge branch 'unstable' into feature/cli-token-path

8b52d34

syjn99 requested a review from michaelsproul November 18, 2024 10:34

chong-he added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Nov 20, 2024

chong-he reviewed Nov 20, 2024

View reviewed changes

book/src/help_vc.md Outdated Show resolved Hide resolved

syjn99 and others added 2 commits November 20, 2024 13:59

Applt review: help_vc.md

92155f1

Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>

Fix help for cli

21358f4

syjn99 requested a review from chong-he November 20, 2024 12:02

syjn99 and others added 2 commits November 21, 2024 12:20

Fix issues on ci

aef92d8

Merge branch 'unstable' into feature/cli-token-path

5aa6833

Merge branch 'unstable' into feature/cli-token-path

0eea85b

michaelsproul added the v7.0.0-beta.0 New release c. Q1 2025 label Dec 3, 2024

syjn99 and others added 2 commits December 3, 2024 20:25

Merge branch 'unstable' into feature/cli-token-path

60210b9

Merge branch 'unstable' into feature/cli-token-path

625f8f0

jimmygchen approved these changes Dec 13, 2024

View reviewed changes

jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Dec 13, 2024

michaelsproul approved these changes Dec 13, 2024

View reviewed changes

mergify bot added a commit that referenced this pull request Dec 16, 2024

Merge of #6577

5582701

mergify bot merged commit 11e1d5b into sigp:unstable Dec 16, 2024
30 checks passed

jimmygchen mentioned this pull request Dec 16, 2024

Add --http-token-path flag to the VC #6563

Closed

jimmygchen mentioned this pull request Jan 1, 2025

Fix incorrect VC default HTTP token path when the --datadir flag is present #6748

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CLI flag for HTTP API token path (VC) #6577

Add CLI flag for HTTP API token path (VC) #6577

syjn99 commented Nov 9, 2024 •

edited

Loading

CLAassistant commented Nov 9, 2024 •

edited

Loading

michaelsproul left a comment

syjn99 commented Nov 18, 2024

chong-he left a comment •

edited

Loading

syjn99 commented Nov 24, 2024

syjn99 commented Dec 3, 2024

jimmygchen left a comment

jimmygchen commented Dec 16, 2024

mergify bot commented Dec 16, 2024 •

edited

Loading

michaelsproul commented Dec 16, 2024

mergify bot commented Dec 16, 2024

mergify bot commented Dec 16, 2024

jimmygchen commented Dec 16, 2024

mergify bot commented Dec 16, 2024

mergify bot commented Dec 16, 2024 •

edited

Loading

Add CLI flag for HTTP API token path (VC) #6577

Add CLI flag for HTTP API token path (VC) #6577

Conversation

syjn99 commented Nov 9, 2024 • edited Loading

Issue Addressed

Proposed Changes

Additional Info

CLAassistant commented Nov 9, 2024 • edited Loading

michaelsproul left a comment

Choose a reason for hiding this comment

syjn99 commented Nov 18, 2024

chong-he left a comment • edited Loading

Choose a reason for hiding this comment

syjn99 commented Nov 24, 2024

syjn99 commented Dec 3, 2024

jimmygchen left a comment

Choose a reason for hiding this comment

jimmygchen commented Dec 16, 2024

mergify bot commented Dec 16, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

michaelsproul commented Dec 16, 2024

mergify bot commented Dec 16, 2024

mergify bot commented Dec 16, 2024

✅ The pull request has been removed from the queue default

jimmygchen commented Dec 16, 2024

mergify bot commented Dec 16, 2024

✅ This pull request will be re-embarked automatically

mergify bot commented Dec 16, 2024 • edited Loading

✅ The pull request has been merged automatically

syjn99 commented Nov 9, 2024 •

edited

Loading

CLAassistant commented Nov 9, 2024 •

edited

Loading

chong-he left a comment •

edited

Loading

mergify bot commented Dec 16, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

✅ The pull request has been removed from the queue `default`

mergify bot commented Dec 16, 2024 •

edited

Loading