-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI flag for HTTP API token path (VC) #6577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request!
This looks good on the whole, just a few minor tweaks and then we can merge
@michaelsproul |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some manual testing and it works well!
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
@michaelsproul @chong-he |
@michaelsproul It seems that there are some flaky tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the PR!
@mergify queue |
🛑 The pull request has been removed from the queue
|
@mergify dequeue |
This pull request has been removed from the queue for the following reason: Pull request #6577 has been dequeued by a You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
✅ The pull request has been removed from the queue
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 11e1d5b |
Issue Addressed
#6563
Proposed Changes
http-token-path
flag for users who want to set the token path explicity.Additional Info
http-token-path
is actually a directory.