Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI flag for HTTP API token path (VC) #6577

Merged
merged 15 commits into from
Dec 16, 2024

Conversation

syjn99
Copy link

@syjn99 syjn99 commented Nov 9, 2024

Issue Addressed

#6563

Proposed Changes

  • Added http-token-path flag for users who want to set the token path explicity.
  • Added documentation for CLI reference, etc.

Additional Info

  • Throw error when http-token-path is actually a directory.
  • If parent directory doesn't exist, make parent directory.

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2024

CLA assistant check
All committers have signed the CLA.

@syjn99 syjn99 changed the title [WIP] Add cli flag for HTTP API token path (VC) Add cli flag for HTTP API token path (VC) Nov 10, 2024
@syjn99 syjn99 changed the title Add cli flag for HTTP API token path (VC) Add CLI flag for HTTP API token path (VC) Nov 10, 2024
@syjn99 syjn99 marked this pull request as ready for review November 10, 2024 06:00
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

This looks good on the whole, just a few minor tweaks and then we can merge

@michaelsproul michaelsproul added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Nov 15, 2024
@syjn99
Copy link
Author

syjn99 commented Nov 18, 2024

@michaelsproul
Fixed things you mentioned! Sorry for delay, enjoyed Devcon a lot 🙇‍♂️

@syjn99 syjn99 requested a review from michaelsproul November 18, 2024 10:34
@chong-he chong-he added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Nov 20, 2024
Copy link
Member

@chong-he chong-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some manual testing and it works well!

syjn99 and others added 2 commits November 20, 2024 13:59
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
@syjn99 syjn99 requested a review from chong-he November 20, 2024 12:02
@syjn99
Copy link
Author

syjn99 commented Nov 24, 2024

@michaelsproul @chong-he
Could you please check this one more time? I applied reviews, fixed things that broke CI jobs.

@michaelsproul michaelsproul added the v7.0.0-beta.0 New release c. Q1 2025 label Dec 3, 2024
@syjn99
Copy link
Author

syjn99 commented Dec 3, 2024

@michaelsproul It seems that there are some flaky tests for make test-network. I'm not sure but it might be related to #6646.

Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Dec 13, 2024
@jimmygchen
Copy link
Member

@mergify queue

Copy link

mergify bot commented Dec 16, 2024

queue

🛑 The pull request has been removed from the queue default

Pull request #6577 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul
Copy link
Member

@mergify dequeue

Copy link

mergify bot commented Dec 16, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #6577 has been dequeued by a dequeue command.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link

mergify bot commented Dec 16, 2024

dequeue

✅ The pull request has been removed from the queue default

@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Dec 16, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Dec 16, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 11e1d5b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v7.0.0-beta.0 New release c. Q1 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants