Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data column gossip validation and error handling #6181

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Data column gossip validation and error handling #6181

merged 3 commits into from
Jul 29, 2024

Conversation

jimmygchen
Copy link
Member

Issue Addressed

Part of #6072.

Adds data column gossip validation and error handling.

Proposed Changes

Upstream PR from das branch:

@jimmygchen jimmygchen added ready-for-review The code is ready for review das Data Availability Sampling das-unstable-merge labels Jul 25, 2024
@jimmygchen jimmygchen force-pushed the das-gossip-validation branch from a990a7a to 6bad1f7 Compare July 25, 2024 13:39
@jimmygchen jimmygchen mentioned this pull request Jul 25, 2024
Closed
@jimmygchen jimmygchen requested a review from pawanjay176 July 25, 2024 13:39
pawanjay176
pawanjay176 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, very tidy

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 26, 2024
@jimmygchen
Copy link
Member Author

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jul 29, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 19b3ab3

mergify bot added a commit that referenced this pull request Jul 29, 2024
@mergify
Merge of #6181
0526089
This was referenced Jul 29, 2024
Closed
Merged
Merged
@mergify mergify bot merged commit 19b3ab3 into sigp:unstable Jul 29, 2024
28 checks passed
@jimmygchen jimmygchen deleted the das-gossip-validation branch July 29, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

Assignees
No one assigned
Labels
das Data Availability Sampling das-unstable-merge ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmygchen @pawanjay176