Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidecar inclusion proof optimisations #4968

Closed
wants to merge 8 commits into from
Closed

Sidecar inclusion proof optimisations #4968

wants to merge 8 commits into from

Conversation

pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

  1. Avoid computing beacon_block_body merkle branches multiple times
  2. Add a proposer signature cache to avoid verifying proposer signature across blocks and blobs.

Testing these optimisations on devnet-12/kurtosis

@realbigsean realbigsean added ready-for-review The code is ready for review deneb labels Dec 1, 2023
@pawanjay176 pawanjay176 force-pushed the proposer-signature-cache branch from e981f2b to ed37f61 Compare December 5, 2023 08:26
@pawanjay176
Copy link
Member Author

Running this on a devnet node to see if we get improvements in gossip verification and proof generation times

@realbigsean realbigsean deleted the branch sigp:sidecar-inclusion-proof December 5, 2023 16:20
@realbigsean realbigsean closed this Dec 5, 2023
@michaelsproul
Copy link
Member

This PR needs a rebase on unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deneb do-not-merge ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawanjay176 @michaelsproul @realbigsean