-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move BitList
and BitVector
to ethereum_ssz
#25
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e012b17
Add bitvector
macladson f088a3a
Also export Fixed and Variable
macladson 16b8b1d
Fix tests
macladson 6fea0d1
Also export Bitfield
macladson 90804d4
Formatting
macladson c8a1294
Merge remote-tracking branch 'origin/main' into bitvector
michaelsproul 91b5130
Add `BitList::resize`
michaelsproul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Also export Fixed and Variable
- Loading branch information
commit f088a3aa00af46b7caaa110f989d2472b0222a71
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've hidden these types in the docs which I believe means the current documentation should remain unchanged.
Since we are re-exporting the Bitfield types in
ssz_types
the documentation for them will still exist in that crate. Like it does now.There might be an argument for moving the documentation across (or duplicating it), but I'm loosely in favour of this approach for now.