Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of ring dependency + loosen dependency requirements #6

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

DragonDev1906
Copy link
Contributor

See #5
@michaelsproul

I've also checked compatibility with the following and loosened the restrictions on the other dependencies (except for wasm-bindgen):

cargo +nightly -Z minimal-versions update && cargo test
# Or this where the above didn't work due to transitive dependencies
cargo +nightly -Z direct-minimal-versions update && cargo test

It should also be possible to use ring = ">= 0.16, < 1.18", which wouldn't force a breaking change as far as I can tell, though due to this recommendation in https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#multiple-version-requirements I'm not sure if that's a good idea.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c04d683) 55.07% compared to head (863fe20) 52.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   55.07%   52.17%   -2.90%     
==========================================
  Files           1        1              
  Lines          69       69              
==========================================
- Hits           38       36       -2     
- Misses         31       33       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelsproul michaelsproul merged commit 37d0706 into sigp:main Nov 30, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants