Add lockbud to CI #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@eserilev do you have a way to reproduce this - as in some sample rust that will trigger output from lockbud? If yes, I can try get it to fail the workflow. |
|
you should be able to force a deadlock with the following snippet If its easier you can revert the changes in this commit here in LH: lockbud will report a deadlock |
# Conflicts: # .github/workflows/test-suite.yml
|
@magick93, I have introduced such a failure: https://github.com/sigp/anchor/actions/runs/12806469752/job/35705033682?pr=83#step:5:1312 - hope it helps! |
jking-aus
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds lockbud to CI w/ one caveat
The caveat is the CI job never actually fails. Even if a deadlock is found, it'll just log the deadlock in CI, but wont return an error code. We have an issue up in LH here to eventually fix this
So yeah, not the most ideal CI job... but still might be nice to have until we get the job to fail correctly