-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock database state globally and implement state watching #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacholme7
reviewed
Jan 28, 2025
Zacholme7
reviewed
Jan 28, 2025
Zacholme7
reviewed
Jan 28, 2025
Zacholme7
reviewed
Jan 28, 2025
small comments/questions, otherwise lgtm gj |
Merged
diegomrsantos
force-pushed
the
global-state-lock
branch
from
January 31, 2025 09:45
63543df
to
34289bc
Compare
dknopik
force-pushed
the
global-state-lock
branch
from
February 4, 2025 15:01
94090a8
to
2e4a34b
Compare
dknopik
force-pushed
the
global-state-lock
branch
from
February 4, 2025 15:13
2e4a34b
to
a3a0bf3
Compare
Zacholme7
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Before this PR, the in-memory database was a bit spooky: As operations (such as adding/removing validators) touch several
DashMap
s without locking the whole state, readers might read inconsistent data across these maps. Reasoning about these maps and safe orders in accessing/updating them is kind of hard, especially as the client is still evolving rapidly.Furthermore, other parts of the client are interested in DB updates, but currently have no way of receiving them except polling regularly.
Proposed Changes
Instead of relying on multiple
DashMap
s andAtomic*
, we now lock the wholeNetworkState
until we are fully done modifying it. We do this by usingtokio::sync::watch
, which is basically aArc<RwLock<T>>
with some extra infrastructure for task notification if the value changed. We use this notification feature invalidator_store
to only load new validators if the state changed, and will use it innetwork
to figure out the subnets we want to subscribe to.