From 1299478fe56450bab7b958157194cdbe2d02940d Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Sun, 27 Aug 2023 13:38:03 +0300 Subject: [PATCH 1/4] Fix lock to sign date property --- CHANGELOG.md | 3 ++- .../TestData/FakeModels/SignNowDocumentFaker.cs | 1 - SignNow.Net/Model/ComplexTags/DateValidatorTag.cs | 3 +-- .../Model/FieldContents/FieldJsonAttributes.cs | 12 ++++++++++++ 4 files changed, 15 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dfc504b9..49dcbe9d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org). ## [Unreleased] - TBD ### Added - `IEventSubscription` interface for any operation with Events -- Webhooks 2.0 API are implemented +- Webhooks 2.0 API partially implemented +- `ValidatorId` and `LockToSignDate` properties added to the signNow document model (`FieldJsonAttributes`) ### Changed - Token type is always set to `Bearer` or `Basic` explicitly in every service diff --git a/SignNow.Net.Test/TestData/FakeModels/SignNowDocumentFaker.cs b/SignNow.Net.Test/TestData/FakeModels/SignNowDocumentFaker.cs index cf37c49f..186619fc 100644 --- a/SignNow.Net.Test/TestData/FakeModels/SignNowDocumentFaker.cs +++ b/SignNow.Net.Test/TestData/FakeModels/SignNowDocumentFaker.cs @@ -1,4 +1,3 @@ -using System.IO; using Bogus; using SignNow.Net.Model; diff --git a/SignNow.Net/Model/ComplexTags/DateValidatorTag.cs b/SignNow.Net/Model/ComplexTags/DateValidatorTag.cs index 19a4fbc9..c601407e 100644 --- a/SignNow.Net/Model/ComplexTags/DateValidatorTag.cs +++ b/SignNow.Net/Model/ComplexTags/DateValidatorTag.cs @@ -16,8 +16,7 @@ public class DateValidatorTag : ComplexTagWithLabel /// /// Lock Signing Date option /// - [JsonProperty("lsd", Order = 1)] - [JsonConverter(typeof(BoolToStringYNJsonConverter))] + [JsonProperty("lock_to_sign_date", Order = 1)] public bool LockSigningDate { get; set; } /// diff --git a/SignNow.Net/Model/FieldContents/FieldJsonAttributes.cs b/SignNow.Net/Model/FieldContents/FieldJsonAttributes.cs index 76a9f145..2ad1253a 100644 --- a/SignNow.Net/Model/FieldContents/FieldJsonAttributes.cs +++ b/SignNow.Net/Model/FieldContents/FieldJsonAttributes.cs @@ -60,5 +60,17 @@ public class FieldJsonAttributes /// [JsonProperty("name")] public string Name { get; set; } + + /// + /// Use the current date when the recipient is signing the document as a Date field value. + /// + [JsonProperty("lock_to_sign_date", NullValueHandling = NullValueHandling.Ignore)] + public bool LockToSignDate { get; set; } + + /// + /// ID of regular expression validator supported by signNow. + /// + [JsonProperty("validator_id", NullValueHandling = NullValueHandling.Ignore)] + public string ValidatorId { get; set; } } } From 87610bd5a7a733720790e6f66b125ffc8823ec33 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Sun, 27 Aug 2023 14:39:44 +0300 Subject: [PATCH 2/4] Bump dependency version --- SignNow.Net.Examples/SignNow.Net.Examples.csproj | 4 ++-- SignNow.Net.Test/SignNow.Net.Test.csproj | 2 +- SignNow.Net/SignNow.Net.csproj | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/SignNow.Net.Examples/SignNow.Net.Examples.csproj b/SignNow.Net.Examples/SignNow.Net.Examples.csproj index 4b3feea6..32ff08d1 100644 --- a/SignNow.Net.Examples/SignNow.Net.Examples.csproj +++ b/SignNow.Net.Examples/SignNow.Net.Examples.csproj @@ -12,11 +12,11 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive - + diff --git a/SignNow.Net.Test/SignNow.Net.Test.csproj b/SignNow.Net.Test/SignNow.Net.Test.csproj index aaac1517..0a796e06 100644 --- a/SignNow.Net.Test/SignNow.Net.Test.csproj +++ b/SignNow.Net.Test/SignNow.Net.Test.csproj @@ -18,7 +18,7 @@ - + diff --git a/SignNow.Net/SignNow.Net.csproj b/SignNow.Net/SignNow.Net.csproj index 9218e574..573d52ab 100644 --- a/SignNow.Net/SignNow.Net.csproj +++ b/SignNow.Net/SignNow.Net.csproj @@ -17,7 +17,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive From fb085383ec92cea61db7ede7155b3370ec43f0d5 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Sun, 27 Aug 2023 14:58:01 +0300 Subject: [PATCH 3/4] Fix test --- .../UnitTests/Models/ComplexTags/ComplexTagsTest.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SignNow.Net.Test/UnitTests/Models/ComplexTags/ComplexTagsTest.cs b/SignNow.Net.Test/UnitTests/Models/ComplexTags/ComplexTagsTest.cs index c29ac7f8..b265e1aa 100644 --- a/SignNow.Net.Test/UnitTests/Models/ComplexTags/ComplexTagsTest.cs +++ b/SignNow.Net.Test/UnitTests/Models/ComplexTags/ComplexTagsTest.cs @@ -220,7 +220,7 @@ public void ShouldSerializeDateValidatorTag() ""required"": true, ""width"": 100, ""height"": 15, - ""lsd"": ""y"", + ""lock_to_sign_date"": true, ""validator_id"": ""13435fa6c2a17f83177fcbb5c4a9376ce85befeb"" }"; From 704659303c51d5fa607c5e6a72e140bf1d396940 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Sun, 27 Aug 2023 15:09:33 +0300 Subject: [PATCH 4/4] Bump version, update changelog --- CHANGELOG.md | 9 ++++++++- SignNow.props | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 49dcbe9d..29fa1592 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com) and this project adheres to [Semantic Versioning](http://semver.org). ## [Unreleased] - TBD + + +## [1.2.2] - 2023-08-27 ### Added - `IEventSubscription` interface for any operation with Events - Webhooks 2.0 API partially implemented @@ -13,6 +16,9 @@ and this project adheres to [Semantic Versioning](http://semver.org). ### Changed - Token type is always set to `Bearer` or `Basic` explicitly in every service +### Fixed +- `LockToSignDate` property serialization for Date validator tag + ## [1.2.1] - 2023-07-13 ### Added @@ -200,7 +206,8 @@ and this project adheres to [Semantic Versioning](http://semver.org). [create freeform invite]: https://github.com/signnow/SignNow.NET/blob/develop/README.md#create-freeform-invite -[Unreleased]: https://github.com/signnow/SignNow.NET/compare/1.2.1...HEAD +[Unreleased]: https://github.com/signnow/SignNow.NET/compare/1.2.2...HEAD +[1.2.2]: https://github.com/signnow/SignNow.NET/compare/1.2.1...1.2.2 [1.2.1]: https://github.com/signnow/SignNow.NET/compare/1.2.0...1.2.1 [1.2.0]: https://github.com/signnow/SignNow.NET/compare/1.1.1...1.2.0 [1.1.1]: https://github.com/signnow/SignNow.NET/compare/1.1.0...1.1.1 diff --git a/SignNow.props b/SignNow.props index 27c2d72c..80fb8bc1 100644 --- a/SignNow.props +++ b/SignNow.props @@ -1,6 +1,6 @@ - 1.2.1-dev + 1.2.2 signNow signNow SignNow.NET