Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new states for MariaDB Jira Blocker and Critical issues #704

Draft
wants to merge 27 commits into
base: develop
Choose a base branch
from

Conversation

caffeinated92
Copy link
Collaborator

@caffeinated92 caffeinated92 commented Jul 9, 2024

Caution!
This will make the alert and prevent failover/switchover for JIRA blockers:

  1. https://jira.mariadb.org/browse/MDEV-28310

For better state checking, state from server will always have serverURL, and it will be added to list for same state. (previously it was ignored)

serverURL can be multiple : A:3306,B:3306,C:3306

@caffeinated92 caffeinated92 changed the title add new alert for replication check MDEV-28310 add new alert for replication check blocker (from MDEV) Jul 9, 2024
@caffeinated92 caffeinated92 changed the title add new alert for replication check blocker (from MDEV) add new alert for replication check blocker Jul 9, 2024
@caffeinated92 caffeinated92 changed the title add new alert for replication check blocker add new alert for MariaDB Jira Blocker and Critical STATE Jul 9, 2024
@svaroqui svaroqui changed the title add new alert for MariaDB Jira Blocker and Critical STATE Add new states for MariaDB Jira Blocker and Critical issues Jul 9, 2024
@caffeinated92
Copy link
Collaborator Author

image

@caffeinated92
Copy link
Collaborator Author

caffeinated92 commented Jul 15, 2024

The MariaDB version has bug in service for this version, source: https://jira.mariadb.org/browse/MDEV-31779 channel=StdOut cluster=fr code=MD031779 status=OPENED type=state

@caffeinated92 caffeinated92 marked this pull request as ready for review July 16, 2024 05:41
@svaroqui
Copy link
Collaborator

svaroqui commented Jul 16, 2024

One can see that https://jira.mariadb.org/browse/MDEV-31779 is about having sequences in schema
and the other critical one is having on duplicate key update

So my proposal was to have mdev-stopper.json where we {issue:"MDEV-31779", tags "sequences"} blabla blocker should block failover only if both version and tags match
In our case we would never block until we are able to detect workload cluster tags sequences , onduplicatekey

@caffeinated92
Copy link
Collaborator Author

Yes, currently MDEV list is only giving alert, only MDEV-28310 is blocker.

blockers := []string{
		"MDEV-28310",
	}

	for _, mdev := range blockers {
		if sl.MDevIssues.HasMdevBug(mdev) {
			return false
		}
	}

	return true

Need to check and adding configurator tags based on situation

@caffeinated92 caffeinated92 marked this pull request as draft July 17, 2024 06:00
@caffeinated92
Copy link
Collaborator Author

On hold while focusing for finishing backups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants