Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13 Migrate from ADODB to PDO #23

Closed
wants to merge 4 commits into from
Closed

#13 Migrate from ADODB to PDO #23

wants to merge 4 commits into from

Conversation

alexgt9
Copy link
Member

@alexgt9 alexgt9 commented Jul 2, 2013

Related to the issue #13

I have implemented this for use PDO. It doesn't have compatibility with adodb but can coexist with the old model.

Just extends from DatabaseModel and thats all.
It work almost like the other one, with the LoadBalancer, the debug and that kind of things, just change the method to access like PDO.
Query, prepare and execute, in addition of affectedRows and lastInsertId .

Do you think that it's a good approximation?

@alombarte
Copy link
Contributor

My first question would be:

@alexgt9
Copy link
Member Author

alexgt9 commented Jul 3, 2013

Because I saw it as only for MySql and I think i a new structure for any kind of driver.
I copy some parts from them. But I added Debug and LoadBalancer as the ADODB connection.

@alombarte
Copy link
Contributor

But your class is Mysql-centric too... Plus you haved copied/pasted a lot
of methods (not desired). What is the real benefit for SIFO to allow such a
pull request? It does not help the migration from ADODB either, which is
the true intention of issue #16

2013/7/3 alexgt9 notifications@github.com

Because I saw it as only for MySql and I think i a new structure for any
kind of driver.
I copy some parts from them. But I added Debug and LoadBalancer as the
ADODB connection.


Reply to this email directly or view it on GitHubhttps://github.com//pull/23#issuecomment-20407895
.

@alombarte alombarte closed this Aug 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants