Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ix-select to correctly select known items in ediable mode on enter navigation #1659

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

matthiashader
Copy link
Collaborator

💡 What is the current behavior?

  • (editable) selection of element through the input field (i.e writting "Item 1" and then press Enter) will always result in the last selected item

GitHub Issue Number: Closes #1579, [IX-2032]

🆕 What is the new behavior?

  • It will be checked if the item exists
  • If the item exists, the selection will be correspondigly updated
  • dropdown closes

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: a0b3f20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthiashader matthiashader changed the title feat: adapt animation behavior fix ix-select to correctly select known items in ediable mode on enter navigation Jan 21, 2025
.changeset/dirty-garlics-unite.md Outdated Show resolved Hide resolved
@matthiashader matthiashader requested a review from jul-lam January 28, 2025 12:54
@danielleroux danielleroux merged commit d28d621 into main Jan 29, 2025
15 checks passed
@danielleroux danielleroux deleted the fix/2032-select branch January 29, 2025 08:03
This was referenced Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iX-Select: inconsistent reaction on enter key
3 participants