chore: track opened grpc connections #10284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsseng
approved these changes
Feb 3, 2025
smira
approved these changes
Feb 3, 2025
DmitriyMV
force-pushed
the
detect-fix-leaks
branch
from
b938bbf to
8d36b55
Compare
|
@dsseng done as an Example - if those contain |
DmitriyMV
force-pushed
the
detect-fix-leaks
branch
from
8d36b55 to
0431403
Compare
This is an alternative to siderolabs#10283 which doesn't close the connections and instead allows us to easily track the lost grpc connections using pprof. Fix various grpc leaks while we are at it. Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
force-pushed
the
detect-fix-leaks
branch
from
0431403 to
98d56d4
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #10283 which doesn't close the connections and instead allows us to easily track the lost grpc connections using pprof.
Fix various grpc leaks while we are at it.