MS1 of ShutterTEE: encrypt persistence #572
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port from the previous efforts at https://github.com/perun-network/shutter which mistaknely targeted the old repository. It would be good to mark the old repository as out of use, and to mark the rolling-shutter repository as being the thing that's now relevant. Sadly, due to the wildly different scheme for persistence, almost none of the effort besidse the tee package could be copied over.
For the review, I recommend to first look in detail at the keyper/tee package, and then look at the rest of the changes. The README in the tee package gives additional information and context about the project, as do the package comments of the tee package. These clearly state the intended security properties and effects. Since we are not overly familiar with the nuances of Shutter, please also check whether we missed any sensitive fields.
Steps taken: