Redact sensitive values on config logging #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmir
reviewed
Sep 21, 2023
| } | ||
| } | ||
|
|
||
| // GetSensitiveRecursive will return all sensitive config paths. | ||
| func GetSensitiveRecursive(root Config) map[string]any { |
There was a problem hiding this comment.
We use struct{} as the value type for maps used like sets. I think we should also do this here as it makes the code a bit clearer. In case I'm wrong and we need the value, I don't understand why this isn't a bool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces another
shconfigtagsensitive.When using the
LogConfigfunction, all values tagged with sensitive will be redacted upon logging and a(sensitive)value will be shown instead.The tree-traversal based dict-parsing function might not be the most efficient, but logging of the config values is expected to be done infrequently / once only.