Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-origin remotes for commit omnicompletion #19

Open
mcepl opened this issue Mar 6, 2018 · 2 comments
Open

Support non-origin remotes for commit omnicompletion #19

mcepl opened this issue Mar 6, 2018 · 2 comments

Comments

@mcepl
Copy link

mcepl commented Mar 6, 2018

I have managed in the end to make omnicompletion to work. I have added g:gitlab_api_keys variable:

let g:fugitive_gitlab_domains = [
    \ 'https://gitlab.com',
    \ 'https://gitlab.internal.site.com'
    \ ]

let g:gitlab_api_keys = {'gitlab.com': 'somethingverysecret'}

Then I had to discover that appropriate remote for git must be origin (that's a pity, I usually use upstream as a name of my remote; but I can survive).

@mcepl mcepl changed the title A bit more documentai A bit more documentation would be welcome Mar 6, 2018
@shumphrey
Copy link
Owner

shumphrey commented Mar 10, 2018

Regarding the documentation, I'm not sure what else I could add, those settings are listed in the README and the vim doc, certainly open to suggestions.

Regarding the origin remote, I completely agree. Its a real shame that it requires origin.
I spent some time trying to work out a way of using different remotes, but its quite complicated.
vim-rhubarb requires origin for the omnicompletion remote also.
There are several issues with the remote calculation, including what should happen when a git repo has a remote for github and gitlab (which is something I have) or gitlab.com and private gitlab.
I do intend to revisit this problem in the future.

@mcepl
Copy link
Author

mcepl commented Mar 11, 2018

You are right about everything else. Could we get at least some variable like g:gitlab_upstreams (dict with names of upstream defaulting to origin)?

@shumphrey shumphrey changed the title A bit more documentation would be welcome Support non-origin remotes for commit omnicompletion Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants