Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Rework #1

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

refactor: Rework #1

wants to merge 28 commits into from

Conversation

Ash258
Copy link

@Ash258 Ash258 commented Jan 15, 2022 •
edited
Loading

TODOs:

  • Do not set cache if not default or not provided
  • Boolean options
  • Support installation using git
    • Proxy
  • Support caching of archives
  • Add Base bucket
  • Shadow parameters using environment variables
  • Support installation of specific branch
  • Support Skipping robocopy check
  • Add additional logging
  • Support NanoServer installations
  • Documentation

TODO:

  • Test caching
  • Test git installation
  • Test no caching
  • Test admin installs
  • Test non admin installs

Ash258 added 21 commits January 9, 2022 05:36
@Ash258
style: Format
0125606
@Ash258
chore: Change URLS
5360223
@Ash258
style: Small tweaks
46daaed
@Ash258
feat: Support installation via git if installed
f285a62
@Ash258
feat: Install base bucket
297ff0b
@Ash258
feat: Add ScoopBranch parameter
93915e2
@Ash258
feat: Add SkipRobocopy parameter
a8efa73
@Ash258
feat: Support installation from locally cached zip archives
7fa31e9 
TODO: Improve wording
@Ash258
style: Unify
f8258fa
@Ash258
chore: Extract download/extract to function
c512dc3
@Ash258
style: Lint
60b20ac
@Ash258
fix: Fail when HOME/USERPROFILE does not exist
795f204
@Ash258
style: Break after git cloning to keep rest cleaner
f2eb3c1
@Ash258
fix: Properly suport extraction of any core zip
e001b7d
@Ash258
fix: Save all needed config options
b7c3a3e
@Ash258
feat: Suport caching of zips -InstallerCacheDir
d10ce20
@Ash258
fix: lastUpdate format
53a46ef
@Ash258
feat: Add global shim directory to global path if administrator
45847e0
@Ash258
fix: Configure SCOOP, SCOOP_GLOBAL, SCOOP_CACHE allways
9ac1fe0
@Ash258
fix: Configure current shell envs
94e5aa8
@Ash258
try to cast with string param. Consider remove type of $Value
b944a5a
@Ash258 Ash258 added the enhancement New feature or request label Jan 15, 2022
@Ash258 Ash258 self-assigned this Jan 15, 2022
@Ash258 Ash258 mentioned this pull request Jan 28, 2022
Draft
@Ash258
Copy link
Author

Ash258 commented Jan 28, 2022

In general it works fine.

Lets extrat this into multiple PRs

@Ash258 Ash258 mentioned this pull request Jan 28, 2022
Merged
Ash258 added a commit that referenced this pull request Jan 29, 2022
@Ash258
ref: Explicit Test-Path calls
db7a4d1 
Extraction 2 of #1
@Ash258 Ash258 mentioned this pull request Jan 29, 2022
Merged
Ash258 added a commit that referenced this pull request Jan 29, 2022
@Ash258
fix: Adopt shovel commands automatically
16d6471 
Extraction 3 of #1
@Ash258 Ash258 mentioned this pull request Jan 29, 2022
Merged
Ash258 added a commit that referenced this pull request Jan 29, 2022
@Ash258
ref: Extract download into function
8ac8952 
Extraction 4 of #1
@Ash258 Ash258 mentioned this pull request Jan 29, 2022
Merged
Ash258 added a commit that referenced this pull request Jan 29, 2022
@Ash258
fix: Use UTF8 for all saved files
5e499b7 
Test if escape is needed in multiline

Extraction 5 of #1
@Ash258 Ash258 mentioned this pull request Jan 29, 2022
Merged
Ash258 added a commit that referenced this pull request May 6, 2023
@Ash258
feat: Add SkipRobocopy parameter
345c0e2 
Extraction 6 of #1
This was referenced May 6, 2023
Merged
Merged
Ash258 added a commit that referenced this pull request May 6, 2023
@Ash258
feat: Install Base bucket
e2df3f4 
Extraction 8 of #1

Additional verbose logs
@Ash258 Ash258 mentioned this pull request May 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ash258 Ash258

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ash258